From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH] Ignore pending_signals when checking for quits.
Date: Wed, 13 Feb 2019 17:28:58 +0200
Message-ID: <834l97pv0l.fsf@gnu.org>
References: <83y36nl7rl.fsf@gnu.org> <20190211201739.25229-1-phst@google.com>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="198466"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: phst@google.com, emacs-devel@gnu.org
To: Philipp Stephani <p.stephani2@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 13 16:29:41 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1gtwTl-000pUl-8K
	for ged-emacs-devel@m.gmane.org; Wed, 13 Feb 2019 16:29:41 +0100
Original-Received: from localhost ([127.0.0.1]:58574 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1gtwTj-0003ys-Ve
	for ged-emacs-devel@m.gmane.org; Wed, 13 Feb 2019 10:29:40 -0500
Original-Received: from eggs.gnu.org ([209.51.188.92]:52442)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1gtwTD-0003yc-LI
	for emacs-devel@gnu.org; Wed, 13 Feb 2019 10:29:08 -0500
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47715)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1gtwTD-0002TU-6V; Wed, 13 Feb 2019 10:29:07 -0500
Original-Received: from [176.228.60.248] (port=2018 helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1gtwTC-00018q-Pq; Wed, 13 Feb 2019 10:29:07 -0500
In-reply-to: <20190211201739.25229-1-phst@google.com> (message from Philipp
	Stephani on Mon, 11 Feb 2019 21:17:39 +0100)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:233276
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/233276>

> From: Philipp Stephani <p.stephani2@gmail.com>
> Cc: Philipp Stephani <phst@google.com>
> Date: Mon, 11 Feb 2019 21:17:39 +0100
> 
> pending_signals is often set if no quit is pending.  This results in
> bugs in module code if the module returns but no quit is actually
> pending.
> 
> As a better alternative, add a new process_input environment function
> for Emacs 27.  That function processes signals (like maybe_quit).

Thanks, this LGTM.