From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [platform-testers] Emacs 26.2 RC1 is out! Date: Fri, 22 Mar 2019 10:25:31 +0300 Message-ID: <834l7vtlp0.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="55498"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: "Nelson H. F. Beebe" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 22 08:35:11 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h7Ehr-000EGY-4j for ged-emacs-devel@m.gmane.org; Fri, 22 Mar 2019 08:35:11 +0100 Original-Received: from localhost ([127.0.0.1]:53256 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7Ehn-00086Y-4P for ged-emacs-devel@m.gmane.org; Fri, 22 Mar 2019 03:35:07 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57658) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7Ee2-0005qC-QF for emacs-devel@gnu.org; Fri, 22 Mar 2019 03:31:19 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:53037) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7EYV-00061d-JP; Fri, 22 Mar 2019 03:25:31 -0400 Original-Received: from [176.228.60.248] (port=2993 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h7EYU-0008FL-7t; Fri, 22 Mar 2019 03:25:31 -0400 In-reply-to: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234520 Archived-At: > Date: Thu, 21 Mar 2019 16:35:50 -0600 > From: "Nelson H. F. Beebe" > Cc: beebe@math.utah.edu > > CC emacsgtkfixed.o > In file included from /usr/lib/glib-2.0/include/glibconfig.h:9:0, > from /usr/include/glib-2.0/glib/gtypes.h:32, > from /usr/include/glib-2.0/glib/galloca.h:32, > from /usr/include/glib-2.0/glib.h:30, > from /usr/include/gtk-3.0/gdk/gdkconfig.h:13, > from /usr/include/gtk-3.0/gdk/gdk.h:30, > from /usr/include/gtk-3.0/gtk/gtk.h:30, > from xterm.h:49, > from emacsgtkfixed.c:25: > emacsgtkfixed.c: In function ‘emacs_fixed_get_type’: > /usr/include/glib-2.0/glib/gmacros.h:232:53: error: size of array ‘_GStaticAssertCompileTimeAssertion_3’ is negative Sounds like a compatibility problem between GTK headers and that port of GCC. IOW, it doesn't look like an Emacs problem, as those headers are not Emacs headers. > However, the lcms2.h header file is installed at > /usr/include/lcms/lcms2.h, rather than at top level in /usr/include. > > The workaround was easy: > > gmake CFLAGS="-I${prefix}/include -I/usr/include/lcms" > > A scan of several of my build farm machines showed that most do not > even have lcms2, but those that do, have it in /usr/include, EXCEPT > for some members of the Solaris family (Oracle Solaris and Hipster). > > Presumably, the emacs-26.x configure.ac file could be tweaked to check > in /usr/include/lcms as well as /usr/include. Our configure doesn't look for the header file at all, so it isn't just a matter of adding one more directory to search. I think we should use pkg-config to detect the correct switches. Does that system have an lcms2/pc file and pkg-config, and does the following command show the correct -I switch: pkg-config --cflags lcms2 It's too bad we know this only now, because I don't think I'd like to delay Emacs 26.2 release due to this issue. (I believe Emacs 26.1 also doesn't compile on that system for the same reason?) End users could either use your workaround or configure without lcms2. Thanks again for your testing.