From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Towards a cleaner build: hexl Date: Fri, 17 May 2019 16:26:31 +0300 Message-ID: <834l5tb4ag.fsf@gnu.org> References: Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="251659"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 17 15:27:48 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hRctn-0013Lq-Ea for ged-emacs-devel@m.gmane.org; Fri, 17 May 2019 15:27:47 +0200 Original-Received: from localhost ([127.0.0.1]:48654 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRctm-0005IM-ER for ged-emacs-devel@m.gmane.org; Fri, 17 May 2019 09:27:46 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59560) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRcsy-00057Y-6d for emacs-devel@gnu.org; Fri, 17 May 2019 09:26:57 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:54301) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRcsw-0002jZ-No; Fri, 17 May 2019 09:26:54 -0400 Original-Received: from [176.228.60.248] (port=3085 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hRcsu-0000y3-Cb; Fri, 17 May 2019 09:26:54 -0400 In-reply-to: (message from Lars Ingebrigtsen on Fri, 17 May 2019 14:45:23 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236668 Archived-At: > From: Lars Ingebrigtsen > Date: Fri, 17 May 2019 14:45:23 +0200 > > (let ((encoded (encode-coding-char ch coding)) > (internal (string-as-unibyte (char-to-string ch))) > internal-hex) > ;; If encode-coding-char returns nil, it means our character > ;; cannot be safely encoded with buffer-file-coding-system. > ;; In that case, we offer to insert the internal representation > ;; of that character, byte by byte. > > And here we really, really want the internal byte representation of the > multibyte string, so I think the code is correct and just needs a > with-no-warnings? I mean, > > (with-suppressed-warnings ((obsolete string-as-unibyte)) > (string-as-unibyte (char-to-string ch))) Howe about this instead: (let ((encoded (encode-coding-char ch coding)) (internal (char-to-string ch)) internal-hex) ;; If encode-coding-char returns nil, it means our character ;; cannot be safely encoded with buffer-file-coding-system. ;; In that case, we offer to insert the internal representation ;; of that character, byte by byte. (when (null encoded) (setq internal (encode-coding-string internal 'utf-8-emacs) internal-hex (mapconcat (function (lambda (c) (format "%x" c))) internal " ")))) Does this work?