From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Native line numbers landed on master Date: Mon, 10 Jun 2019 18:54:06 +0300 Message-ID: <834l4xbfmp.fsf@gnu.org> References: <83k23jl5ra.fsf@gnu.org> <87bmolqryw.fsf@wavexx.thregr.org> <83blz5bh2m.fsf@gnu.org> <87h88x4fqw.fsf@wavexx.thregr.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="223645"; mail-complaints-to="usenet@blaine.gmane.org" Cc: lekktu@gmail.com, emacs-devel@gnu.org To: Yuri D'Elia Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 10 17:54:29 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1haMcv-000w2V-3Z for ged-emacs-devel@m.gmane.org; Mon, 10 Jun 2019 17:54:29 +0200 Original-Received: from localhost ([::1]:47856 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1haMcu-0000dz-4L for ged-emacs-devel@m.gmane.org; Mon, 10 Jun 2019 11:54:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55097) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1haMcg-0000ds-16 for emacs-devel@gnu.org; Mon, 10 Jun 2019 11:54:14 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:53200) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1haMcf-0002gq-53; Mon, 10 Jun 2019 11:54:13 -0400 Original-Received: from [176.228.60.248] (port=3816 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1haMcc-0000rr-41; Mon, 10 Jun 2019 11:54:11 -0400 In-reply-to: <87h88x4fqw.fsf@wavexx.thregr.org> (message from Yuri D'Elia on Mon, 10 Jun 2019 17:33:27 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237410 Archived-At: > From: Yuri D'Elia > Cc: Juanma Barranquero , emacs-devel@gnu.org > Date: Mon, 10 Jun 2019 17:33:27 +0200 > > But as a side note: is this really that impactful to add a regular hook? It's a feature creep that I would like to avoid. > Surely this would (?) be run only for visible lines No, that's not true. The display code is also called for portions of text that aren't going to be displayed, when Emacs needs to figure out dimensions of some text or perform layout calculations without displaying anything. As just one example, vertical-motion, which is at the core of any vertical motion command (C-n, C-p, etc.) does that. Another popular example is posn-at-point. > If you restrict to certain face properties such as face > colors, you can ensure there's no change in width. How can we justify support for only some faces? This is the kind of a slippery slope that I would like to avoid. Too many display features let users do stuff with unimaginable leeway, and we pay for that both in performance and in maintainability. I'm trying to avoid such feature creep in this case, be that as un-emacsy as it might seem.