From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Tab bar tabs landed on master
Date: Wed, 02 Oct 2019 20:07:06 +0300
Message-ID: <834l0r84at.fsf@gnu.org>
References: <8736gci5jn.fsf@mail.linkov.net>
 <CAAeL0SQiNE0ay5C8cG2wzjJEVFHoTu=MV8-_4-ixyi0X_bTKWQ@mail.gmail.com>
 <83muej8a0f.fsf@gnu.org> <87zhijqfys.fsf@mail.linkov.net>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="94053"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: lekktu@gmail.com, emacs-devel@gnu.org
To: Juri Linkov <juri@linkov.net>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 02 19:21:03 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1iFiJC-000OKp-Tz
	for ged-emacs-devel@m.gmane.org; Wed, 02 Oct 2019 19:21:03 +0200
Original-Received: from localhost ([::1]:57940 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1iFiJA-0002U0-SM
	for ged-emacs-devel@m.gmane.org; Wed, 02 Oct 2019 13:21:00 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37202)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>) id 1iFi60-0005sS-1a
 for emacs-devel@gnu.org; Wed, 02 Oct 2019 13:07:24 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57361)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
 id 1iFi5z-0001Lu-Hn; Wed, 02 Oct 2019 13:07:23 -0400
Original-Received: from [176.228.60.248] (port=1087 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1iFi5y-0001Nb-Sa; Wed, 02 Oct 2019 13:07:23 -0400
In-reply-to: <87zhijqfys.fsf@mail.linkov.net> (message from Juri Linkov on
 Wed, 02 Oct 2019 19:27:47 +0300)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:240477
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/240477>

> From: Juri Linkov <juri@linkov.net>
> Date: Wed, 02 Oct 2019 19:27:47 +0300
> Cc: Juanma Barranquero <lekktu@gmail.com>, emacs-devel@gnu.org
> 
> Tab-bar code is just a copy of tool-bar code.  And indeed
> running `emacs -Q -f tool-bar-mode' that disables tool-bar-mode
> exposes the same problem:
> 
> (let ((initial (assq 'outer-size (frame-geometry))))
>   (tool-bar-mode 1)
>   (tool-bar-mode 0)
>   (list (assq 'outer-size (frame-geometry)) initial))
> 
> => ((outer-size 680 . 693) (outer-size 680 . 676))

I don't see any problem here.  As I understand it, the problem with
tab bars is twofold:

  . turning on tab-bar-mode on GUI frames behaves differently on
    GNU/Linux and MS-Windows

  . turning on tab-bar-mode on TTY frames on MS-Windows produces a
    broken frame

We should fix these problems; what you show for tool bar is not a
problem, but the expected behavior, AFAICT.

Martin, am I right?