From: Eli Zaretskii <eliz@gnu.org>
To: "João Távora" <joaotavora@gmail.com>
Cc: larsi@gnus.org, cpitclaudel@gmail.com, monnier@iro.umontreal.ca,
emacs-devel@gnu.org
Subject: Re: jit-lock-antiblink-grace
Date: Sat, 12 Oct 2019 12:34:11 +0300 [thread overview]
Message-ID: <834l0enw8c.fsf@gnu.org> (raw)
In-Reply-To: <CALDnm53DUVXJ8wHpNxKdHmwLqaAjf9DU=qyrp9zQPwZc46qb=g@mail.gmail.com> (message from João Távora on Thu, 10 Oct 2019 23:34:25 +0100)
> From: João Távora <joaotavora@gmail.com>
> Date: Thu, 10 Oct 2019 23:34:25 +0100
>
> A while back I coded up a feature in a scratch branch that
> I dubbed the "antiblink". It helps avoid the fontification "blinking"
> behaviour observed when creating temporarily unterminated
> strings to source code.
>
> I recall that Lars and Clément tested it with generally positive results.
>
> At Stefan's request, I have reworked the implementation and
> cleaned up the feature, which is embodied in the jit-lock-antiblink-grace
> variable and want to land it on master if no-one objects.
>
> If you want to try it before that happens see the
> scratch/jit-lock-antiblink-cleaned-up branch.
Bother: this unconditionally adds a post-command-hook, which will
necessarily slow down paging through a file. If there's no better
solution than using that over-used hook, then at the very least we
should give users a way of NOT adding a post-command-hook when this
feature is disabled.
Some more comments about the code:
> +** New customizable variable 'jit-lock-antiblink-grace'
This line should end in a period
> +Setting this to a positive number of seconds helps avoid the
> +fontification "blinking" behaviour observed when adding temporarily
> +unterminated strings to source code. If the user has recently created
> +an unterminated string at EOL, jit fontification allows this idle
> +"grace" period to elapse before deciding it is a multi-line string and
> +fontifying the remainder of the buffer accordingly.
This should be simplified and shortened. (In general, copy/paste of
doc strings into NEWS is not a good idea.) In particular, if the
default is to have this behavior (see below), the NEWS entry should
tell how to disable that.
> +(defcustom jit-lock-antiblink-grace 2
> + "Like `jit-lock-context-time' but for unterminated multiline strings.
> +Setting this to a positive number of seconds helps avoid the
> +fontification \"blinking\" behaviour observed when adding
> +temporarily unterminated strings to source code. If the user has
> +recently created an unterminated string at EOL, allow for an idle
> +\"grace\" period to elapse before deciding it is a multi-line
> +string and fontifying the remainder of the buffer accordingly."
> + :type '(number :tag "seconds")
> + :group 'jit-lock)
This new defcustom should have a :version tag.
The doc string should say how to disable the feature. Also, the doc
string makes it sound like the default is not a positive number of
seconds by default, but it is. (I question the wisdom of making this
the default behavior, btw.)
I don't understand the "at EOL" part: isn't any unterminated string
appear as if it is "at EOL"?
> +(defvar jit-lock--antiblink-l-b-p (make-marker)
> + "Last line beginning position (l-b-p) after last command (a marker).")
> +(defvar jit-lock--antiblink-i-s-o-c nil
> + "In string or comment (i-s-o-c) after last command (a boolean).")
Please don't use such cryptic variable names, at least not on the file
level (preferably also not locally inside functions).
> + (add-hook 'post-command-hook 'jit-lock--antiblink-post-command nil t)
As mentioned above, this hook should not be added if the feature is
disabled.
> + (when jit-lock--antiblink-grace-timer
> + (message "internal warning: `jit-lock--antiblink-grace-timer' not null"))
We should in general avoid calling 'message' here, because such a
message will appear after every command, which is a nuisance. Is this
really needed?
Thanks.
next prev parent reply other threads:[~2019-10-12 9:34 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 22:34 jit-lock-antiblink-grace João Távora
2019-10-11 14:26 ` jit-lock-antiblink-grace Stefan Monnier
2019-10-12 9:34 ` Eli Zaretskii [this message]
2019-10-12 10:57 ` jit-lock-antiblink-grace João Távora
2019-10-12 13:02 ` jit-lock-antiblink-grace Juanma Barranquero
2019-10-12 13:14 ` jit-lock-antiblink-grace João Távora
2019-10-12 14:50 ` jit-lock-antiblink-grace Juanma Barranquero
2019-10-12 15:11 ` jit-lock-antiblink-grace João Távora
2019-10-12 15:30 ` jit-lock-antiblink-grace Juanma Barranquero
2019-10-12 13:32 ` jit-lock-antiblink-grace Eli Zaretskii
2019-10-12 14:13 ` jit-lock-antiblink-grace Stefan Monnier
2019-10-12 14:23 ` jit-lock-antiblink-grace Eli Zaretskii
2019-10-12 14:34 ` jit-lock-antiblink-grace Stefan Monnier
2019-10-12 15:57 ` jit-lock-antiblink-grace Eli Zaretskii
2019-10-12 17:16 ` jit-lock-antiblink-grace Stefan Monnier
2019-10-12 17:50 ` jit-lock-antiblink-grace Eli Zaretskii
2019-10-12 15:47 ` jit-lock-antiblink-grace Alan Mackenzie
2019-10-12 14:23 ` jit-lock-antiblink-grace João Távora
2019-10-12 16:04 ` jit-lock-antiblink-grace Eli Zaretskii
2019-10-12 21:55 ` jit-lock-antiblink-grace João Távora
2019-10-13 6:39 ` jit-lock-antiblink-grace Eli Zaretskii
2019-10-13 8:47 ` jit-lock-antiblink-grace João Távora
2019-10-13 9:22 ` jit-lock-antiblink-grace Eli Zaretskii
2019-10-13 10:28 ` jit-lock-antiblink-grace João Távora
2019-10-13 10:45 ` jit-lock-antiblink-grace Eli Zaretskii
2019-10-14 23:29 ` jit-lock-antiblink-grace João Távora
2019-10-15 6:48 ` jit-lock-antiblink-grace Eli Zaretskii
2019-10-15 18:28 ` jit-lock-antiblink-grace João Távora
2019-11-24 1:04 ` jit-lock-antiblink-grace João Távora
2019-11-24 16:16 ` jit-lock-antiblink-grace Eli Zaretskii
2019-11-25 18:46 ` jit-lock-antiblink-grace Alan Mackenzie
2019-11-25 19:02 ` jit-lock-antiblink-grace João Távora
2019-11-25 19:26 ` jit-lock-antiblink-grace Alan Mackenzie
2019-11-25 19:45 ` jit-lock-antiblink-grace João Távora
2019-11-25 20:11 ` jit-lock-antiblink-grace Alan Mackenzie
2019-11-25 20:23 ` jit-lock-antiblink-grace João Távora
2019-11-25 21:07 ` jit-lock-antiblink-grace João Távora
2019-11-26 2:30 ` jit-lock-antiblink-grace João Távora
2019-11-26 17:58 ` jit-lock-antiblink-grace Eli Zaretskii
2019-11-30 19:11 ` jit-lock-antiblink-grace João Távora
2019-11-30 19:22 ` jit-lock-antiblink-grace Eli Zaretskii
2019-11-30 20:12 ` jit-lock-antiblink-grace João Távora
2019-11-30 20:16 ` jit-lock-antiblink-grace Eli Zaretskii
2019-11-30 20:19 ` jit-lock-antiblink-grace João Távora
2019-11-30 20:41 ` jit-lock-antiblink-grace Eli Zaretskii
2019-11-30 22:00 ` jit-lock-antiblink-grace João Távora
2019-12-01 18:13 ` jit-lock-antiblink-grace Eli Zaretskii
2019-12-04 22:45 ` jit-lock-antiblink-grace João Távora
2019-12-05 15:40 ` jit-lock-antiblink-grace Eli Zaretskii
2019-11-26 13:43 ` jit-lock-antiblink-grace Stefan Monnier
2019-11-25 19:47 ` jit-lock-antiblink-grace Dmitry Gutov
2019-11-25 20:03 ` jit-lock-antiblink-grace João Távora
2019-10-12 16:14 ` jit-lock-antiblink-grace Alan Mackenzie
2019-10-12 22:26 ` jit-lock-antiblink-grace João Távora
2019-10-13 10:18 ` jit-lock-antiblink-grace Alan Mackenzie
2019-10-13 10:48 ` jit-lock-antiblink-grace João Távora
2019-10-13 12:02 ` jit-lock-antiblink-grace Alan Mackenzie
2019-10-13 19:57 ` jit-lock-antiblink-grace João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834l0enw8c.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=cpitclaudel@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=joaotavora@gmail.com \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).