Re: master ab36b56 1/2: ; * src/font.h (font_is_ignored): Add prototype to avoid warnings.

Re: master ab36b56 1/2: ; * src/font.h (font_is_ignored): Add prototype to avoid warnings.

[Robert Pluim]

>>>>> On Thu, 14 Nov 2019 06:51:59 -0500 (EST), eliz@gnu.org (Eli Zaretskii) said:

    Eli> branch: master
    Eli> commit ab36b56e40c6af3b3deb8ad768e410d4838615f9
    Eli> Author: Eli Zaretskii <eliz@gnu.org>
    Eli> Commit: Eli Zaretskii <eliz@gnu.org>

    Eli>     ; * src/font.h (font_is_ignored): Add prototype to avoid warnings.
    Eli> ---
 
    Eli>  extern bool font_match_p (Lisp_Object spec, Lisp_Object font);
    Eli> +extern bool font_is_ignored (const char *name, ptrdiff_t namelen);
    Eli>  extern Lisp_Object font_list_entities (struct frame *, Lisp_Object);
 
    Eli>  extern Lisp_Object font_get_name (Lisp_Object font_object);

Hmm, with which compiler? The definition of that function is just
before its first use, so the prototype should not be necessary (and
now we have two prototypes for that function, the other is in
gtkutil.h).

Robert

Re: master ab36b56 1/2: ; * src/font.h (font_is_ignored): Add prototype to avoid warnings.

[Eli Zaretskii]

> From: Robert Pluim <rpluim@gmail.com>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Thu, 14 Nov 2019 13:26:13 +0100
> 
>     Eli>     ; * src/font.h (font_is_ignored): Add prototype to avoid warnings.
>     Eli> ---
>  
>     Eli>  extern bool font_match_p (Lisp_Object spec, Lisp_Object font);
>     Eli> +extern bool font_is_ignored (const char *name, ptrdiff_t namelen);
>     Eli>  extern Lisp_Object font_list_entities (struct frame *, Lisp_Object);
>  
>     Eli>  extern Lisp_Object font_get_name (Lisp_Object font_object);
> 
> Hmm, with which compiler?

GCC 7.3.0.

> The definition of that function is just before its first use

The paranoid warning options used by the developers' build causes GCC
to complain about non-static functions that have no prototype in
scope.

> (and now we have two prototypes for that function, the other is in
> gtkutil.h).

That one should be removed, because gkutil.c (indirectly) includes
font.h, AFAICT.

Re: master ab36b56 1/2: ; * src/font.h (font_is_ignored): Add prototype to avoid warnings.

[Robert Pluim]

>>>>> On Thu, 14 Nov 2019 16:24:38 +0200, Eli Zaretskii <eliz@gnu.org> said:

    >> Hmm, with which compiler?

    Eli> GCC 7.3.0.

    >> The definition of that function is just before its first use

    Eli> The paranoid warning options used by the developers' build causes GCC
    Eli> to complain about non-static functions that have no prototype in
    Eli> scope.

Oh, I donʼt run configure with --enable-gcc-warnings (I seem to
remember Paul warning against that).

    >> (and now we have two prototypes for that function, the other is in
    >> gtkutil.h).

    Eli> That one should be removed, because gkutil.c (indirectly) includes
    Eli> font.h, AFAICT.

Yes, which causes lots of warnings in a GTK build. Removed.

Robert

Re: master ab36b56 1/2: ; * src/font.h (font_is_ignored): Add prototype to avoid warnings.

[Eli Zaretskii]

> From: Robert Pluim <rpluim@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Thu, 14 Nov 2019 15:41:52 +0100
> 
>     Eli> The paranoid warning options used by the developers' build causes GCC
>     Eli> to complain about non-static functions that have no prototype in
>     Eli> scope.
> 
> Oh, I donʼt run configure with --enable-gcc-warnings (I seem to
> remember Paul warning against that).

Neither do I.  But --enable-checking turns it on, AFAIR.

>     >> (and now we have two prototypes for that function, the other is in
>     >> gtkutil.h).
> 
>     Eli> That one should be removed, because gkutil.c (indirectly) includes
>     Eli> font.h, AFAICT.
> 
> Yes, which causes lots of warnings in a GTK build. Removed.

Thanks.

Re: master ab36b56 1/2: ; * src/font.h (font_is_ignored): Add prototype to avoid warnings.

[Paul Eggert]

On 11/14/19 6:41 AM, Robert Pluim wrote:
> Oh, I donʼt run configure with --enable-gcc-warnings (I seem to
> remember Paul warning against that).

I warn against it for people who are just building Emacs, as it 
generates so many false alarms. For developers it can be useful, though, 
as we can silence the false alarms and change the warnings options if 
there are too many warnings.

If you're building from git (as opposed to building from a tarball), 
--enable-gcc-warnings='warn-only' is the default, because the assumption 
is that you're at least a developer-lite.