From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Hollow cursor under images Date: Tue, 28 Jan 2020 20:22:38 +0200 Message-ID: <834kwfo2z5.fsf@gnu.org> References: <83bm2qea01.fsf@gnu.org> <20190304223605.GA22198@breton.holly.idiocy.org> <83k15coil1.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="110367"; mail-complaints-to="usenet@ciao.gmane.io" Cc: alan@idiocy.org, emacs-devel@gnu.org To: Evgeny Zajcev Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jan 28 20:42:04 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iwWkN-000Sf2-PP for ged-emacs-devel@m.gmane-mx.org; Tue, 28 Jan 2020 20:42:03 +0100 Original-Received: from localhost ([::1]:36650 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iwWkM-0006Uv-SR for ged-emacs-devel@m.gmane-mx.org; Tue, 28 Jan 2020 14:42:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46872) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iwVVd-0002aZ-RG for emacs-devel@gnu.org; Tue, 28 Jan 2020 13:22:46 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60748) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iwVVd-0005Qw-KH; Tue, 28 Jan 2020 13:22:45 -0500 Original-Received: from [176.228.60.248] (port=3863 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iwVVb-0000uY-Bh; Tue, 28 Jan 2020 13:22:44 -0500 In-reply-to: (message from Evgeny Zajcev on Tue, 28 Jan 2020 14:55:39 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:244725 Archived-At: > From: Evgeny Zajcev > Date: Tue, 28 Jan 2020 14:55:39 +0300 > Cc: Alan Third , emacs-devel > > I tried to fulfill all the review comments in this updated patch Thanks. A few minor comments below. > * buffer.c (cursor-type): Add commentary about (box . WIDTH) > cursor-type End this sentence with a period. > * xdisp.c (get_specified_cursor_type): Check for `cursor-type' in form > (box . WIDTH) Likewise. > * xdisp.c (get_window_cursor_type): Check masked image size for > (box . WIDTH) cursor-type. Changes in several functions in the same file should mention the file name just once. Like this: * xdisp.c (get_specified_cursor_type): Check for `cursor-type' in form '(box . WIDTH)'. ((get_window_cursor_type): Check masked image size for(box . WIDTH) cursor-type. > * doc/emacs/display.texi, doc/emacs/display.texi: Add description > for (box . WIDTH) `cursor-type' > > * etc/NEWS: Add note about (box . WIDTH) `cursor-type' Period missing at end of each sentence. > +@code{(box . @var{width})} (box cursor becoming a hollow box under > +masked images larger than @var{width} in either dimension), I think it's better to use "size", not 'width" here, because "width" is closely associated with only one dimension, and you mean both. Or maybe even "min-size", for better mnemonic value. > +** Support for `(box . WIDTH)' cursor-type. By default, `box' cursor > +always has a filled box shape. Unless you specify cursor-type to be > +`(box . WIDTH)'. In such case, cursor becomes a hollow box if the > +point is under masked image larger than `WIDTH' in any dimension. The first sentence of a NEWS entry should be alone on the header line. That's because NEWS is visited in Outline mode, where users can hide the text of the entry, leaving just the headings. So leave only the first sentence on the heading line, and move all the rest to the body starting from the next line. Also, we prefer quoting 'like this' in NEWS (and in log messages, btw).