From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Why are so many great packages not trying to get included in GNU Emacs? Date: Fri, 08 May 2020 09:26:12 +0300 Message-ID: <834ksrj62j.fsf@gnu.org> References: <9mmFgzvrBwjt_n_VJyaJdXINraNi5HsGpwq-0MLeKiJA7kG2BQA4uywrzjyz7lpRS0OZDpjEi8lspOKYUA7P_QsODsDew_8nbH960G55fmY=@protonmail.com> <97DA7804-F647-4A1D-B8E0-AFFE7A324C64@gmail.com> <15bc138f-1c12-d8d2-7174-12a243030634@yandex.ru> <609f9461-8c02-dcf4-773d-562b8d1f717c@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="7139"; mail-complaints-to="usenet@ciao.gmane.io" Cc: cpitclaudel@gmail.com, ilya.ostapyshyn@gmail.com, casouri@gmail.com, emacs-devel@gnu.org, dgutov@yandex.ru, ndame@protonmail.com To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri May 08 08:28:44 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jWwV2-0001k1-BE for ged-emacs-devel@m.gmane-mx.org; Fri, 08 May 2020 08:28:44 +0200 Original-Received: from localhost ([::1]:48090 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWwV1-0002te-Dq for ged-emacs-devel@m.gmane-mx.org; Fri, 08 May 2020 02:28:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46612) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWwSo-00007m-E6 for emacs-devel@gnu.org; Fri, 08 May 2020 02:26:26 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:39933) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWwSn-0005vi-BT; Fri, 08 May 2020 02:26:25 -0400 Original-Received: from [176.228.60.248] (port=3768 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jWwSm-0002Y5-GG; Fri, 08 May 2020 02:26:25 -0400 In-Reply-To: (message from =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= on Thu, 7 May 2020 21:28:23 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:249244 Archived-At: > From: João Távora > Date: Thu, 7 May 2020 21:28:23 +0100 > Cc: ndame , Yuan Fu , > Emacs developers , Dmitry Gutov > > I got confused by this part: why do you need the cookie? > > Because I changed the commit message: here's the commit I was > talking about earlier (from git.sv.gnu.org:/srv/git/emacs/elpa.git) > > commit 4953ee6f7de4ead0fced02e0da823eafaf5797e0 > Author: Ilya Ostapyshyn > Date: Thu May 7 20:34:14 2020 +0300 > > Fix #13: correctly calculate search bound for narrowed buffers > > The search-forward function does not take narrowing into account, so we must > do that ourselves. > > Co-authored-by: João Távora > Copyright-paperwork-exempt: yes > > * darkroom.el (darkroom-guess-margins): Add (point-min) to the 20000 > > I added all the commit message, but Ilya did the actual patch. > > Though reading Luke's email, it seems I could have use > "Signed-off-by:" or something like that. See CONTRIBUTE: we are asking not to use Signed-off-by. As for Co-authored-by, this is IMO a borderline case: a change in the commit log message does not necessarily mean you become a co-author. But it doesn't do any harm, so it's your call whether to use it in such cases. I don't, FWIW.