From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.diffs,gmane.emacs.devel
Subject: Re: emacs-27 41232e6: Avoid crashes due to bidi cache being reset
 during redisplay
Date: Sun, 31 May 2020 18:46:25 +0300
Message-ID: <834krwksz2.fsf@gnu.org>
References: <20200531142645.22884.78754@vcs0.savannah.gnu.org>
 <20200531142647.08FCA20A2B@vcs0.savannah.gnu.org>
 <CAOqdjBe1wd1ozvsZALz8bemVHjxj=nWkxZViZ8Rm6JvjVXsfXw@mail.gmail.com>
 <837dwskuiy.fsf@gnu.org>
 <CAOqdjBeApp9=yzog+QLO0je6n4Cz28VHyPwyJCuHyKvpjvr4NQ@mail.gmail.com>
Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202";
	logging-data="107256"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-diffs@gnu.org, emacs-devel@gnu.org
To: Pip Cet <pipcet@gmail.com>
Original-X-From: emacs-diffs-bounces+gnu-emacs-diffs=m.gmane-mx.org@gnu.org Sun May 31 17:46:30 2020
Return-path: <emacs-diffs-bounces+gnu-emacs-diffs=m.gmane-mx.org@gnu.org>
Envelope-to: gnu-emacs-diffs@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-diffs-bounces+gnu-emacs-diffs=m.gmane-mx.org@gnu.org>)
	id 1jfQAP-000Rp3-Up
	for gnu-emacs-diffs@m.gmane-mx.org; Sun, 31 May 2020 17:46:29 +0200
Original-Received: from localhost ([::1]:36966 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-diffs-bounces+gnu-emacs-diffs=m.gmane-mx.org@gnu.org>)
	id 1jfQAO-0004HV-Vw
	for gnu-emacs-diffs@m.gmane-mx.org; Sun, 31 May 2020 11:46:29 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50442)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1jfQAL-0004HK-Cs; Sun, 31 May 2020 11:46:25 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55977)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1jfQAL-0004X3-3T; Sun, 31 May 2020 11:46:25 -0400
Original-Received: from [176.228.60.248] (port=4909 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1jfQAK-0002FV-Hq; Sun, 31 May 2020 11:46:24 -0400
In-Reply-To: <CAOqdjBeApp9=yzog+QLO0je6n4Cz28VHyPwyJCuHyKvpjvr4NQ@mail.gmail.com>
 (message from Pip Cet on Sun, 31 May 2020 15:36:22 +0000)
X-BeenThere: emacs-diffs@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Mailing list for Emacs changes <emacs-diffs.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-diffs>,
 <mailto:emacs-diffs-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-diffs>
List-Post: <mailto:emacs-diffs@gnu.org>
List-Help: <mailto:emacs-diffs-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-diffs>,
 <mailto:emacs-diffs-request@gnu.org?subject=subscribe>
Errors-To: emacs-diffs-bounces+gnu-emacs-diffs=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-diffs"
 <emacs-diffs-bounces+gnu-emacs-diffs=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.diffs:156397 gmane.emacs.devel:251680
Archived-At: <http://permalink.gmane.org/gmane.emacs.diffs/156397>

> From: Pip Cet <pipcet@gmail.com>
> Date: Sun, 31 May 2020 15:36:22 +0000
> Cc: emacs-devel@gnu.org, emacs-diffs@gnu.org
> 
> > xmalloc calls memory_full if that happens.
> 
> Sorry, should have been more explicit: if we run out of memory,
> memory_full will signal an error, after freeing some "spare" memory.
> The error handler will call echo_display_area_1. If the bidi iterator
> is in use, the cache size is much larger than the spare memory we
> freed, so the allocation will also fail, and I'm not sure we ever
> recover from that.

Yes, our code is full of such places.  It would be good to improve the
recovery in these cases.