From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master f45ce78 2/2: Explicitly specify svg base_uri using `:base-uri' image property Date: Sat, 19 Dec 2020 12:09:34 +0200 Message-ID: <834kkiumxt.fsf@gnu.org> References: <83o8iyerpi.fsf@gnu.org> <83czzdeogx.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25976"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Evgeny Zajcev Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Dec 19 11:11:02 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kqZCX-0006eW-HN for ged-emacs-devel@m.gmane-mx.org; Sat, 19 Dec 2020 11:11:01 +0100 Original-Received: from localhost ([::1]:60834 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kqZCW-0005t1-I0 for ged-emacs-devel@m.gmane-mx.org; Sat, 19 Dec 2020 05:11:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44406) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kqZBR-0005Cj-Ct for emacs-devel@gnu.org; Sat, 19 Dec 2020 05:09:53 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:53842) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kqZBR-0008U9-0o; Sat, 19 Dec 2020 05:09:53 -0500 Original-Received: from [176.228.60.248] (port=2260 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kqZBQ-0002wL-FG; Sat, 19 Dec 2020 05:09:52 -0500 In-Reply-To: (message from Evgeny Zajcev on Thu, 17 Dec 2020 01:08:12 +0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:261245 Archived-At: > From: Evgeny Zajcev > Date: Thu, 17 Dec 2020 01:08:12 +0300 > Cc: emacs-devel > > Here I've composed the patch. As I can see NEWS already fixed Do you think the current NEWS entry is sufficiently complete and accurate? The patch LGTM, with a couple of wording nits: > * doc/lispref/display.texi: Add more documentation for `:base-uri' This should mention the name of the @node where the change is done, in parentheses (as if it were a function). > diff --git a/doc/lispref/display.texi b/doc/lispref/display.texi > index 2b3119ea59..2ecd14fed9 100644 > --- a/doc/lispref/display.texi > +++ b/doc/lispref/display.texi > @@ -5904,7 +5904,13 @@ SVG Images > To @var{svg} add an embedded (raster) image placed at > @var{relative-filename}. @var{relative-filename} is searched inside > @code{file-name-directory} of the @code{:base-uri} svg image property. > -This improves the performance of embedding large images. > +@code{:base-uri} specifies a (possible non-existing) filename name of ^^^^^^^^ ^^^^^^^^^^^^^ "possibly" and "file name". Thanks.