From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Yikes! easy-menu-add is suddenly compiled to `ignore', without any warning. Date: Wed, 07 Apr 2021 14:37:16 +0300 Message-ID: <834kgiba1f.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6410"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acm@muc.de, stefan@marxist.se, emacs-devel@gnu.org To: Ulrich Mueller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Apr 07 13:38:05 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lU6VZ-0001Zg-Ca for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Apr 2021 13:38:05 +0200 Original-Received: from localhost ([::1]:53666 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lU6VY-00086n-CT for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Apr 2021 07:38:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40382) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lU6Uo-0007fZ-5q for emacs-devel@gnu.org; Wed, 07 Apr 2021 07:37:18 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44102) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lU6Um-00060O-5W; Wed, 07 Apr 2021 07:37:16 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2182 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lU6Uk-0006MN-V9; Wed, 07 Apr 2021 07:37:15 -0400 In-Reply-To: (message from Ulrich Mueller on Wed, 07 Apr 2021 13:24:57 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267505 Archived-At: > From: Ulrich Mueller > Date: Wed, 07 Apr 2021 13:24:57 +0200 > Cc: Alan Mackenzie , emacs-devel@gnu.org > > >>>>> On Wed, 07 Apr 2021, Stefan Kangas wrote: > > > This function is only relevant in XEmacs, so if this is important to > > you I recommend changing any such call to say: > > > (when (featurep 'xemacs) > > (easy-menu-add foo-menu)) > > Why can't it be left in place, though? An alias for "ignore" is cheap > and requires zero maintenance. "Zero maintenance" is an exaggeration, IME. Not every code fragment that uses these compatibility shims is as clear-cut as the snippet above; more often than not, when working on code which references those shims, one needs to dig quite deeply into the sources until he/she understands that the code is a no-op in Emacs. That digging takes/wastes time and effort. > OTOH, removing it will make the life of those people who try to keep > their packages compatible with XEmacs more complicated. I'm sorry, but that ship has sailed several months ago. Gobs of XEmacs compatibility features were removed already, after the removal move was announced. Are you saying we should reinstate all of them back? If not, what is so special about this particular one?