From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: How to add pseudo vector types Date: Wed, 28 Jul 2021 19:43:53 +0300 Message-ID: <834kcetmly.fsf@gnu.org> References: <83h7gw6pyj.fsf@gnu.org> <46BBFF88-76C3-4818-8805-5437409BEA93@gmail.com> <83wnpq46uk.fsf@gnu.org> <533BD53B-4E85-4E9E-B46A-346A5BBAD0F5@gmail.com> <258CB68D-1CC1-42C8-BDCD-2A8A8099B783@gmail.com> <1a776770-50b7-93cd-6591-c9a5b3a56eb8@gmail.com> <8335s64v10.fsf@gnu.org> <5380C92B-6C15-4490-A1E0-1C3132DBB16A@gmail.com> <83k0li2shw.fsf@gnu.org> <86wnpg82v3.fsf@stephe-leake.org> <83lf5wyn0z.fsf@gnu.org> <86pmv66yqg.fsf@stephe-leake.org> <83a6maw705.fsf@gnu.org> <83r1fluikh.fsf@gnu.org> <88007ACB-31E5-440F-876D-9F43C8EE02CC@gmail.com> <86fsw05lom.fsf@stephe-leake.org> <8A3823DD-5D5A-4A33-8EF9-93F05497CE4C@gmail.com> <864kcf5cmv.fsf_-_@stephe-leake.org> <18D745F5-DBB1-46CC-91D3-4ADAA9D37AB9@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39150"; mail-complaints-to="usenet@ciao.gmane.io" Cc: cpitclaudel@gmail.com, stephen_leake@stephe-leake.org, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jul 28 18:45:02 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m8mg0-0009yP-Nx for ged-emacs-devel@m.gmane-mx.org; Wed, 28 Jul 2021 18:45:00 +0200 Original-Received: from localhost ([::1]:34914 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m8mfz-00071E-PQ for ged-emacs-devel@m.gmane-mx.org; Wed, 28 Jul 2021 12:44:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34928) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m8mez-0006Iz-87 for emacs-devel@gnu.org; Wed, 28 Jul 2021 12:43:57 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:32964) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m8mey-0001CA-95; Wed, 28 Jul 2021 12:43:56 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4965 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m8mex-0007cp-TO; Wed, 28 Jul 2021 12:43:56 -0400 In-Reply-To: <18D745F5-DBB1-46CC-91D3-4ADAA9D37AB9@gmail.com> (message from Yuan Fu on Wed, 28 Jul 2021 12:36:33 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271771 Archived-At: > From: Yuan Fu > Date: Wed, 28 Jul 2021 12:36:33 -0400 > Cc: Eli Zaretskii , > Clément Pit-Claudel , > monnier@iro.umontreal.ca, emacs-devel > > > What, exactly, will the buffer-text fetch code do if tree-sitter > > violates the narrowing (by some error in tree-sitter or user code)? > > throw an exception? return a null string? > > In my current implementation, if tree-sitter access buffer content outside of narrowed region, it reads whitespaces, if it access buffer content outside of the buffer, it reads null string. Neither case throws an error. What does TS expect the reader function to return when it hits the beginning or end of buffer text? I think we should behave the same when it tries to go beyond the accessible portion. There should be no difference between going beyond the restriction and going beyond EOB.