unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* build modifies config.guess and config.sub
@ 2021-07-28 20:17 Perry E. Metzger
  2021-07-28 20:27 ` Philipp
  0 siblings, 1 reply; 9+ messages in thread
From: Perry E. Metzger @ 2021-07-28 20:17 UTC (permalink / raw)
  To: emacs-devel

Howdy, all!

Whenever I do a "git status" after cleaning up after a build, I learn 
that the files

build-aux/config.guess
build-aux/config.sub

have been modified. It's easy enough to do a "git restore" on them, but 
should they should actually be checked in? I thought they were supplied 
by the autotools?

Perry





^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: build modifies config.guess and config.sub
  2021-07-28 20:17 build modifies config.guess and config.sub Perry E. Metzger
@ 2021-07-28 20:27 ` Philipp
  2021-07-29  6:06   ` Eli Zaretskii
  0 siblings, 1 reply; 9+ messages in thread
From: Philipp @ 2021-07-28 20:27 UTC (permalink / raw)
  To: Perry E. Metzger; +Cc: Emacs developers



> Am 28.07.2021 um 22:17 schrieb Perry E. Metzger <perry@piermont.com>:
> 
> Howdy, all!
> 
> Whenever I do a "git status" after cleaning up after a build, I learn that the files
> 
> build-aux/config.guess
> build-aux/config.sub
> 
> have been modified. It's easy enough to do a "git restore" on them, but should they should actually be checked in? I thought they were supplied by the autotools?

This issue has been discussed earlier (https://lists.gnu.org/archive/html/emacs-devel/2021-05/msg00130.html), but without conclusion.  Maybe it's worth filing a bug to at least track it properly.


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: build modifies config.guess and config.sub
  2021-07-28 20:27 ` Philipp
@ 2021-07-29  6:06   ` Eli Zaretskii
  2021-07-29 23:11     ` Perry E. Metzger
  0 siblings, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2021-07-29  6:06 UTC (permalink / raw)
  To: Philipp; +Cc: emacs-devel, perry

> From: Philipp <p.stephani2@gmail.com>
> Date: Wed, 28 Jul 2021 22:27:25 +0200
> Cc: Emacs developers <emacs-devel@gnu.org>
> 
> > Am 28.07.2021 um 22:17 schrieb Perry E. Metzger <perry@piermont.com>:
> > 
> > Howdy, all!
> > 
> > Whenever I do a "git status" after cleaning up after a build, I learn that the files
> > 
> > build-aux/config.guess
> > build-aux/config.sub
> > 
> > have been modified. It's easy enough to do a "git restore" on them, but should they should actually be checked in? I thought they were supplied by the autotools?
> 
> This issue has been discussed earlier (https://lists.gnu.org/archive/html/emacs-devel/2021-05/msg00130.html), but without conclusion.

There was a conclusion, from my POV:

  https://lists.gnu.org/archive/html/emacs-devel/2021-05/msg00187.html

To make it more clear, this is an Autoconf misfeature, and if someone
wants to report a bug, it should be reported to the Autoconf
developers; we here have nothing we can do about this kind of
"progress".



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: build modifies config.guess and config.sub
  2021-07-29  6:06   ` Eli Zaretskii
@ 2021-07-29 23:11     ` Perry E. Metzger
  2021-07-30  6:03       ` Eli Zaretskii
  0 siblings, 1 reply; 9+ messages in thread
From: Perry E. Metzger @ 2021-07-29 23:11 UTC (permalink / raw)
  To: emacs-devel

On 7/29/21 02:06, Eli Zaretskii wrote:
>>
>>> Howdy, all!
>>>
>>> Whenever I do a "git status" after cleaning up after a build, I learn that the files
>>>
>>> build-aux/config.guess
>>> build-aux/config.sub
>>>
>>> have been modified. It's easy enough to do a "git restore" on them, but should they should actually be checked in? I thought they were supplied by the autotools?
>> This issue has been discussed earlier (https://lists.gnu.org/archive/html/emacs-devel/2021-05/msg00130.html), but without conclusion.
> There was a conclusion, from my POV:
>
>    https://lists.gnu.org/archive/html/emacs-devel/2021-05/msg00187.html
>
> To make it more clear, this is an Autoconf misfeature, and if someone
> wants to report a bug, it should be reported to the Autoconf
> developers; we here have nothing we can do about this kind of
> "progress".

Couldn't we just not check in those two files?

Perry






^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: build modifies config.guess and config.sub
  2021-07-29 23:11     ` Perry E. Metzger
@ 2021-07-30  6:03       ` Eli Zaretskii
  2021-07-30 13:48         ` Perry E. Metzger
  0 siblings, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2021-07-30  6:03 UTC (permalink / raw)
  To: Perry E. Metzger; +Cc: emacs-devel

> Date: Thu, 29 Jul 2021 19:11:46 -0400
> From: "Perry E. Metzger" <perry@piermont.com>
> 
> > To make it more clear, this is an Autoconf misfeature, and if someone
> > wants to report a bug, it should be reported to the Autoconf
> > developers; we here have nothing we can do about this kind of
> > "progress".
> 
> Couldn't we just not check in those two files?

How will then cloning the repository produce them in the working tree?
Our build process doesn't generate them, and people do use older
versions of Autoconf (I do).



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: build modifies config.guess and config.sub
  2021-07-30  6:03       ` Eli Zaretskii
@ 2021-07-30 13:48         ` Perry E. Metzger
  2021-07-30 13:54           ` Eli Zaretskii
  0 siblings, 1 reply; 9+ messages in thread
From: Perry E. Metzger @ 2021-07-30 13:48 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel

On 7/30/21 02:03, Eli Zaretskii wrote:
>>
>> Couldn't we just not check in those two files?
> How will then cloning the repository produce them in the working tree?
> Our build process doesn't generate them, and people do use older
> versions of Autoconf (I do).
>
We could copy them in during the build. Alternatively, we could check in 
the latest versions; older versions of autoconf won't overwrite them.

Perry




^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: build modifies config.guess and config.sub
  2021-07-30 13:48         ` Perry E. Metzger
@ 2021-07-30 13:54           ` Eli Zaretskii
  2021-07-30 18:35             ` Alan Third
  0 siblings, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2021-07-30 13:54 UTC (permalink / raw)
  To: Perry E. Metzger; +Cc: emacs-devel

> Date: Fri, 30 Jul 2021 09:48:50 -0400
> Cc: emacs-devel@gnu.org
> From: "Perry E. Metzger" <perry@piermont.com>
> 
> On 7/30/21 02:03, Eli Zaretskii wrote:
> >>
> >> Couldn't we just not check in those two files?
> > How will then cloning the repository produce them in the working tree?
> > Our build process doesn't generate them, and people do use older
> > versions of Autoconf (I do).
> >
> We could copy them in during the build.

Sorry, I don't understand what that means in practice.  Please
elaborate.

> Alternatively, we could check in the latest versions; older versions
> of autoconf won't overwrite them.

Don't they come from some external Git repository?  If so, checking in
changed versions is asking for trouble.



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: build modifies config.guess and config.sub
  2021-07-30 13:54           ` Eli Zaretskii
@ 2021-07-30 18:35             ` Alan Third
  2021-07-30 18:53               ` Eli Zaretskii
  0 siblings, 1 reply; 9+ messages in thread
From: Alan Third @ 2021-07-30 18:35 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel, Perry E. Metzger

On Fri, Jul 30, 2021 at 04:54:36PM +0300, Eli Zaretskii wrote:
> > Date: Fri, 30 Jul 2021 09:48:50 -0400
> > Cc: emacs-devel@gnu.org
> > From: "Perry E. Metzger" <perry@piermont.com>
> > 
> > Alternatively, we could check in the latest versions; older versions
> > of autoconf won't overwrite them.
> 
> Don't they come from some external Git repository?  If so, checking in
> changed versions is asking for trouble.

It looks like they normally get updated along with Gnulib.
-- 
Alan Third



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: build modifies config.guess and config.sub
  2021-07-30 18:35             ` Alan Third
@ 2021-07-30 18:53               ` Eli Zaretskii
  0 siblings, 0 replies; 9+ messages in thread
From: Eli Zaretskii @ 2021-07-30 18:53 UTC (permalink / raw)
  To: Alan Third; +Cc: emacs-devel, perry

> Date: Fri, 30 Jul 2021 19:35:25 +0100
> From: Alan Third <alan@idiocy.org>
> Cc: "Perry E. Metzger" <perry@piermont.com>, emacs-devel@gnu.org
> 
> On Fri, Jul 30, 2021 at 04:54:36PM +0300, Eli Zaretskii wrote:
> > > Date: Fri, 30 Jul 2021 09:48:50 -0400
> > > Cc: emacs-devel@gnu.org
> > > From: "Perry E. Metzger" <perry@piermont.com>
> > > 
> > > Alternatively, we could check in the latest versions; older versions
> > > of autoconf won't overwrite them.
> > 
> > Don't they come from some external Git repository?  If so, checking in
> > changed versions is asking for trouble.
> 
> It looks like they normally get updated along with Gnulib.

Yes, I know.



^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2021-07-30 18:53 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-28 20:17 build modifies config.guess and config.sub Perry E. Metzger
2021-07-28 20:27 ` Philipp
2021-07-29  6:06   ` Eli Zaretskii
2021-07-29 23:11     ` Perry E. Metzger
2021-07-30  6:03       ` Eli Zaretskii
2021-07-30 13:48         ` Perry E. Metzger
2021-07-30 13:54           ` Eli Zaretskii
2021-07-30 18:35             ` Alan Third
2021-07-30 18:53               ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).