From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Correct byte compiler error/warning positions. The solution! Date: Wed, 01 Dec 2021 19:08:01 +0200 Message-ID: <834k7ss172.fsf@gnu.org> References: <8335nh29pt.fsf@gnu.org> <83wnktzxb2.fsf@gnu.org> <83ilwcyc6o.fsf@gnu.org> <8335nfw2pe.fsf@gnu.org> <838rx4s224.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14344"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 01 18:25:09 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1msTLx-0003W3-3s for ged-emacs-devel@m.gmane-mx.org; Wed, 01 Dec 2021 18:25:09 +0100 Original-Received: from localhost ([::1]:50188 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1msTLv-0002Xh-1W for ged-emacs-devel@m.gmane-mx.org; Wed, 01 Dec 2021 12:25:07 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50488) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1msT5e-0001Fz-4f for emacs-devel@gnu.org; Wed, 01 Dec 2021 12:08:18 -0500 Original-Received: from [2001:470:142:3::e] (port=58698 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1msT5d-0002ML-PJ; Wed, 01 Dec 2021 12:08:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=oicIG6x9VAKbbpdh8YXebrQDd/4VuoEkhnwGTVohiJk=; b=m+3lxbKxonMm c2SaXgohx6EBAu9Zlrm+6NKSCqP9d9oj+QvzttF/bqv2e6bX7Uwt7M3iIxK8xPjU6gvPpqMRyElzE PG37aKSa9MP6sVk248TCUyFBZMUTRpwnFzGlaC8XbrRu20xS8hoZtRkYhsGH0zH1nekxtRX5U0MxY ylhSWX/L9h76xBpl/DR+hu2VnXpXiP6QDd6HkUBYjwR5vh0CZPqfhOhxcM462XTSf0OR70yD9t7af iJKPY5oHhEbvxtxJiVp4UV9tMwEduQA4NkCaUQ2NWnr1tWoxG991IwOqYFuyanWOCsF60y7Nx54l5 mHGS5p/l7ik7bhb7eXucsA==; Original-Received: from [87.69.77.57] (port=1132 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1msT5d-0003uE-Fw; Wed, 01 Dec 2021 12:08:17 -0500 In-Reply-To: (message from Alan Mackenzie on Wed, 1 Dec 2021 16:58:52 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:280653 Archived-At: > Date: Wed, 1 Dec 2021 16:58:52 +0000 > Cc: emacs-devel@gnu.org > From: Alan Mackenzie > > You asked me for some benchmark figures comparing master with the > scratch/correct-warning-pos branch. I supplied them, and they suggest > that the performance penalty in the new branch is small, around 1%. 1% slowdown is insignificant. But Andrea suggested to use an additional suite of benchmarks, and I thought you were going to do that as well. > I would like to merge this branch, when it becomes stable, into master, > thus finally resolving the bug of the wrong positions in warning > messages from the byte compiler. If all the benchmarks show a slowdown <= 1%, I'm okay with merging it. Thanks.