From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: try_scrolling question
Date: Sat, 04 Dec 2021 10:23:54 +0200 [thread overview]
Message-ID: <834k7o7p7p.fsf@gnu.org> (raw)
In-Reply-To: <87h7bovmye.fsf@yahoo.com> (message from Po Lu on Sat, 04 Dec 2021 15:38:49 +0800)
> From: Po Lu <luangruo@yahoo.com>
> Date: Sat, 04 Dec 2021 15:38:49 +0800
>
> Value is
> ^^^^^
>
> 1 if scrolling succeeded
>
> 0 if scrolling didn't find point.
>
> -1 if new fonts have been loaded so that we must interrupt redisplay,
> adjust glyph matrices, and try again.
>
> Does it mean the return value of try_scrolling?
Yes. "Value is ..." is our style in documenting the return value of a
function.
> If so, I don't understand how 0 (SCROLLING_SUCCESS) is returned if
> it can't find point, and how -1 can be returned at all.
Heh, a classic case of comments not matching the code. The code never
looks at the literal values though, only at enumeration values, so the
code works correctly. I've now fixed the enumeration to match the
comment. Thanks for catching this (very old) blunder.
prev parent reply other threads:[~2021-12-04 8:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87h7bovmye.fsf.ref@yahoo.com>
2021-12-04 7:38 ` try_scrolling question Po Lu
2021-12-04 8:23 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834k7o7p7p.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).