From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master b1e9151: Enable the native display of BMP images on Haiku Date: Sat, 26 Mar 2022 16:18:54 +0300 Message-ID: <834k3kc0n5.fsf@gnu.org> References: <835yo0c2xa.fsf@gnu.org> <87h77k51wf.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40090"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Mar 26 14:19:36 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nY6KN-000AJM-If for ged-emacs-devel@m.gmane-mx.org; Sat, 26 Mar 2022 14:19:35 +0100 Original-Received: from localhost ([::1]:58470 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nY6KM-0004IF-5O for ged-emacs-devel@m.gmane-mx.org; Sat, 26 Mar 2022 09:19:34 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60830) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nY6Jm-0003bA-Cz for emacs-devel@gnu.org; Sat, 26 Mar 2022 09:18:58 -0400 Original-Received: from [2001:470:142:3::e] (port=56172 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nY6Jm-0004AJ-35; Sat, 26 Mar 2022 09:18:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=eRIn9wbCc5Lx2SUFJ1EAPOKZAycVwr3a7pFO2mHLBug=; b=XoZcXXg1d3YC OIiv8E2ClUCDtAkH9BGXv9NLCuXD0bQ9aG3OPFTxkp2372G0Gn/KW3L3l63PZWjOHE/de4yqyWy8u p5rqZ6YmkV2quHVxofmg7mIiXxKUg0aOP6Dw9TjUw77FVpeCn1Iz+tIvq502qbmqppOcJD2cX7KCL Sszt1rA4p1pY95RBt6X57jf1BhTWIni94QPBdbG1CP50WbQZyp88jrGsrWcVtyFFWsavdgmsJYv/B Yi+KS/NM95K7zJXGx3Yhdu6kBrb9XHY4NRBiOq6FpBvdfMFPdG+fSECXD9JB/B8sr/LOIkYtsnKYK 2XeAJFEcvgjchPmkMvmZxw==; Original-Received: from [87.69.77.57] (port=4301 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nY6Jl-0004PS-Io; Sat, 26 Mar 2022 09:18:57 -0400 In-Reply-To: <87h77k51wf.fsf@yahoo.com> (message from Po Lu on Sat, 26 Mar 2022 20:33:36 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287478 Archived-At: > From: Po Lu > Cc: emacs-devel@gnu.org > Date: Sat, 26 Mar 2022 20:33:36 +0800 > > Eli Zaretskii writes: > > >> --- a/src/image.c > >> +++ b/src/image.c > >> @@ -11555,12 +11555,16 @@ syms_of_image (void) > >> > >> #if HAVE_NATIVE_IMAGE_API > >> DEFSYM (Qnative_image, "native-image"); > >> -# ifdef HAVE_NTGUI > >> - DEFSYM (Qgdiplus, "gdiplus"); > >> - DEFSYM (Qshlwapi, "shlwapi"); > >> + > >> +#if defined HAVE_NTGUI || defined HAVE_HAIKU > >> DEFSYM (Qbmp, "bmp"); > >> add_image_type (Qbmp); > >> -# endif > >> +#endif > >> + > >> +#ifdef HAVE_NTGUI > >> + DEFSYM (Qgdiplus, "gdiplus"); > >> + DEFSYM (Qshlwapi, "shlwapi"); > >> +#endif > >> #endif > >> > >> defsubr (&Sinit_image_library); > > > Shouldn't you now remove SEFSYM for Qbmp from haikuimage.c? > > Probably, but it doesn't hurt to keep multiple DEFSYMs around right? It's better not, I think. We don't do that elsewhere, do we?