unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: master b1e9151: Enable the native display of BMP images on Haiku
Date: Sat, 26 Mar 2022 16:18:54 +0300	[thread overview]
Message-ID: <834k3kc0n5.fsf@gnu.org> (raw)
In-Reply-To: <87h77k51wf.fsf@yahoo.com> (message from Po Lu on Sat, 26 Mar 2022 20:33:36 +0800)

> From: Po Lu <luangruo@yahoo.com>
> Cc: emacs-devel@gnu.org
> Date: Sat, 26 Mar 2022 20:33:36 +0800
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> --- a/src/image.c
> >> +++ b/src/image.c
> >> @@ -11555,12 +11555,16 @@ syms_of_image (void)
> >> 
> >>  #if HAVE_NATIVE_IMAGE_API
> >>    DEFSYM (Qnative_image, "native-image");
> >> -# ifdef HAVE_NTGUI
> >> -  DEFSYM (Qgdiplus, "gdiplus");
> >> -  DEFSYM (Qshlwapi, "shlwapi");
> >> +
> >> +#if defined HAVE_NTGUI || defined HAVE_HAIKU
> >>    DEFSYM (Qbmp, "bmp");
> >>    add_image_type (Qbmp);
> >> -# endif
> >> +#endif
> >> +
> >> +#ifdef HAVE_NTGUI
> >> +  DEFSYM (Qgdiplus, "gdiplus");
> >> +  DEFSYM (Qshlwapi, "shlwapi");
> >> +#endif
> >>  #endif
> >> 
> >>    defsubr (&Sinit_image_library);
> 
> > Shouldn't you now remove SEFSYM for Qbmp from haikuimage.c?
> 
> Probably, but it doesn't hurt to keep multiple DEFSYMs around right?

It's better not, I think.  We don't do that elsewhere, do we?



  reply	other threads:[~2022-03-26 13:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-26 12:29 master b1e9151: Enable the native display of BMP images on Haiku Eli Zaretskii
2022-03-26 12:33 ` Po Lu
2022-03-26 13:18   ` Eli Zaretskii [this message]
2022-03-26 13:22     ` Po Lu
2022-03-26 13:29       ` Eli Zaretskii
2022-03-26 13:47         ` Po Lu
2022-03-26 13:58           ` Eli Zaretskii
2022-03-27  0:33             ` Po Lu
2022-03-26 13:49       ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=834k3kc0n5.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).