From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Patch] Avoid recording chars when reading passwords Date: Wed, 08 Jun 2022 18:48:00 +0300 Message-ID: <834k0v5f7z.fsf@gnu.org> References: <87edzz8dzo.fsf@elite.giraud> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2509"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Manuel Giraud Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jun 08 17:49:20 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nyxvr-0000QQ-Up for ged-emacs-devel@m.gmane-mx.org; Wed, 08 Jun 2022 17:49:20 +0200 Original-Received: from localhost ([::1]:39436 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nyxvq-0004xu-HO for ged-emacs-devel@m.gmane-mx.org; Wed, 08 Jun 2022 11:49:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49478) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nyxuj-00047W-Um for emacs-devel@gnu.org; Wed, 08 Jun 2022 11:48:11 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36422) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nyxuj-0006s9-Eb; Wed, 08 Jun 2022 11:48:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=3mvZK/njG7PRGafBMU6EAJKfd6VoW36xjZOXRwAZ3L4=; b=S4ujdabg00B4 lqRmbqbnopwscgb0wRj1ZqTsjn26+ifwoNmuxEBGjrsyKz7O55uKBIygxmyTl8Y0MUsz9SmT2Bw7t HPucKuVm2l0b/s53t2IKJNOibkKSvit5tWQcHeUTysb7pfx3V9ho3Sf7yQfiRXiSDmcKmzCM2jW3e pwIKBPEFK1Xysm8QlfYV85lJWYDkMYGp0FZu9xKV71Y5oP2wGFXM20trwxigP0A4y+RoFuttokBQr 2BqdZhdmjNXdd7pMT4f/tA+6ci/TX/sJkfLguHkU6d4bQTNF2Sa3b2b+BV1hfwsQBwH9rA6vBUfBQ swAnyRoSxIrUCE+3swz5rQ==; Original-Received: from [87.69.77.57] (port=2026 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nyxui-0000Qp-FE; Wed, 08 Jun 2022 11:48:09 -0400 In-Reply-To: <87edzz8dzo.fsf@elite.giraud> (message from Manuel Giraud on Wed, 08 Jun 2022 15:46:19 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290945 Archived-At: > From: Manuel Giraud > Date: Wed, 08 Jun 2022 15:46:19 +0200 > > With this patch, passwords won't appear in the lossage or the dribble > file. We already have a facility for this, see 'no-record' in the description of unread-command-events in the ELisp manual. Please see if you can use that instead. And if you must have a variable, I'd prefer to un-obsolete inhibit--record-char, which was once used for this purpose, but no longer is, and restore the code in keyboard.c which supported it. Thanks.