From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349) Date: Tue, 30 Aug 2022 16:01:04 +0300 Message-ID: <834jxtvqb3.fsf@gnu.org> References: <166171593185.16640.41619657947456727@vcs2.savannah.gnu.org> <20220828194533.23A6BC00889@vcs2.savannah.gnu.org> <87r10znm0y.fsf@gnus.org> <83fshfvvyn.fsf@gnu.org> <83bks3vtf5.fsf@gnu.org> <83tu5uug68.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28428"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, juri@jurta.org, emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 30 15:02:21 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oT0sn-0007Hu-2t for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 15:02:21 +0200 Original-Received: from localhost ([::1]:55758 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oT0sm-0006g4-09 for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 09:02:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55374) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT0rE-0005Hq-0N for emacs-devel@gnu.org; Tue, 30 Aug 2022 09:00:44 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60600) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT0rC-00080h-US; Tue, 30 Aug 2022 09:00:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=I5LI0z3231Uib8jetErVWHntzWZCboZfziITYanjano=; b=EJYDFfum9oMo JQeJEiSuu0TE3RBz3vSLPabdJTxM5B3cTAYnmTNotoZQ4JBDr739wOCg+9pnjDSKA60zYZGj43ZvZ O1bkxL+bE8z59szneq3//TWCM53Y/fifbK30weL/2RvPaD+VpHcfva2ZI3o+3JYpfxqYs1G2uIaIY eSKZqKWzCGSPwNWB7NGqE37ZL1RsgG56pv9Bhxlzw6pVvHIrd9ZURfWTaOs9CdNzNcGq8yvYZysEl M64WtFf2M5PDVxrQQK0gImTmpkmiWjoTZKF4f0+1ciXFJSYQZNu8UeWe3BUnSMB0hIjUqz0ATuiR+ BbIkdyfzvWT4tnjj6sDG7g==; Original-Received: from [87.69.77.57] (port=3845 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT0rC-0002Hw-9m; Tue, 30 Aug 2022 09:00:42 -0400 In-Reply-To: (message from Dmitry Gutov on Tue, 30 Aug 2022 15:35:31 +0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294339 Archived-At: > Date: Tue, 30 Aug 2022 15:35:31 +0300 > Cc: larsi@gnus.org, juri@jurta.org, emacs-devel@gnu.org > From: Dmitry Gutov > > >> Note that "the patch" will usually be a subset of the current 'git diff' > >> output. But not always (the patch can be additionally modified by hand). > > > > I understand. But how is this significant? Doesn't "git apply" > > require a valid patch as well? > > It's significant in that the starting conditions is that the files are > already modified compared to the repository head, and the end goal is to > be able to pick only some of those changes for commit. Ouch! Then this feature will be useless for me, and I'm sorry I wasted everyone's time based on the description in NEWS, which doesn't make a point of emphasizing this basic assumption. > OTOH, the lack of support for workflow corresponding to 'git add -p' has > been complained about frequently, it's one of the reasons people use > Magit, and I felt it as well many times. I cannot agree that this feature is a reasonable solution for the "git add -p" workflow. It is not interactive enough for that.