From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Regression in dump-emacs-portable Date: Wed, 15 Feb 2023 14:42:53 +0200 Message-ID: <834jrncd6a.fsf@gnu.org> References: <83ttzocomk.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1342"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Lynn Winebarger Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Feb 15 13:44:09 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pSH8q-00005S-BF for ged-emacs-devel@m.gmane-mx.org; Wed, 15 Feb 2023 13:44:08 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSH80-0003uN-Rd; Wed, 15 Feb 2023 07:43:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSH7y-0003u7-QF for emacs-devel@gnu.org; Wed, 15 Feb 2023 07:43:14 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSH7x-0005bw-76; Wed, 15 Feb 2023 07:43:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/D2k+CBA2Ng17i+IqNfvNPNGS7PB1oei22dxE9hw41Y=; b=StwBYUoAjUYE COibJZi0F03kkP8xHqiHcWaCOCisz2uOF8WdqKdc+n0uZAm9/AsTFtK8ci335eW8uaRG9RXzXzTvK QOeaQOVXly5JeieLzp8WNi/oHW1U/V7OX6cSyvxr6mFDNg/6yN14xau/q8lZjOZFzpNYsgB1uLmV7 HYkT8wWkwLqmu/Rp6Vk6mGnUZZulqtkb5G9LYtkco3sR6Dmx7ML21N4N4RoW8OftjnOTkyQx+P3Ws HVlO/dPmw2XoPWAgUzFIP3qXomSU0uv3FRFZvY9UU0vvrY7hn+ptU/jk5VlUZf4vGIwWXyz+o1g4T rZ89LFmZoEKojTMKypMypg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSH7w-0003AN-N1; Wed, 15 Feb 2023 07:43:13 -0500 In-Reply-To: (message from Lynn Winebarger on Tue, 14 Feb 2023 18:26:07 -0500) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303302 Archived-At: > From: Lynn Winebarger > Date: Tue, 14 Feb 2023 18:26:07 -0500 > Cc: emacs-devel@gnu.org > > On Tue, Feb 14, 2023 at 9:23 AM Eli Zaretskii wrote: > > > > What do these tests actually test? > > Whether libraries expected to be redumpable are in fact redumpable. That's the goal, not the actual testing algorithm. I asked about the latter. How do you intend to test that a dump succeeded (assuming there's no crash)? > Almost every library in 28.2 could be redumped, excepting those which > simply failed to load for whatever reason. Don't we have Lisp objects that cannot be dumped? If we do, then not every library could be dumped even in principle. Another potential issue with this is (assuming you suggest to actually try dumping every library) that it will take too long, and thus will be likely to be skipped in any "normal" run of the test suite, thus missing the point.