From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: jinx Date: Sat, 01 Apr 2023 15:57:53 +0300 Message-ID: <834jpzzrn2.fsf@gnu.org> References: <87sfdnyuxc.fsf@posteo.de> <83sfdl2z26.fsf@gnu.org> <86tty0ydnl.fsf@gnu.org> <877cuwgg4m.fsf@gmail.com> <83cz4nzw3u.fsf@gnu.org> <87ilef3k77.fsf@gmail.com> <838rfbzuku.fsf@gnu.org> <87a5zrvl3y.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30981"; mail-complaints-to="usenet@ciao.gmane.io" Cc: arash@gnu.org, rms@gnu.org, m.eliachevitch@posteo.de, emacs-devel@gnu.org To: Augusto Stoffel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 01 14:58:43 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1piaoc-0007pf-0R for ged-emacs-devel@m.gmane-mx.org; Sat, 01 Apr 2023 14:58:42 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pianj-0001Mz-RF; Sat, 01 Apr 2023 08:57:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1piani-0001MY-IZ for emacs-devel@gnu.org; Sat, 01 Apr 2023 08:57:46 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1piani-0004KJ-04; Sat, 01 Apr 2023 08:57:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=02oqOZJCeuI5CMnfYa9gZvpCluYd9pXogBi+CAoVmNw=; b=c/hN3Oa813eR PO6sdiUC6MvPgldeucu3+rw558Cr66s2FBPGdf9NR91s+HkYE5q/zdAAjVINMEcwCMfdIXIHz4MuL xqiJ9FfRhrHGEGJhjY1qWiwTEMPCW7o7PG05mEFEq45PFSAUI98DA53EmzosVeKifPG2Vr1tVNPkd SFFqBdsy86dJgPHCV61UEt3beqi/9m7Wgue1XuykpiOrebIePl4LDV9k7mBmFQ/1y/aLt49bf7U6R zH1WHHBRC6L0t/A358juZ+SrqMMbh6bfxOm6aqoz/cNgrdxa2HMYmu4q6jnRYhFDAk4WxLdlBdseD DwiTttAgpu378xHrQqM6MQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1piana-00079H-Ah; Sat, 01 Apr 2023 08:57:39 -0400 In-Reply-To: <87a5zrvl3y.fsf@gmail.com> (message from Augusto Stoffel on Sat, 01 Apr 2023 14:32:33 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304994 Archived-At: > From: Augusto Stoffel > Cc: arash@gnu.org, rms@gnu.org, m.eliachevitch@posteo.de, > emacs-devel@gnu.org > Date: Sat, 01 Apr 2023 14:32:33 +0200 > > On Sat, 1 Apr 2023 at 14:54, Eli Zaretskii wrote: > > > I'm afraid I don't quite follow. I actually don't understand why we > > need END here. Why not call the function with some buffer position, > > and let it return nil (meaning don't skip) or a buffer position, which > > means skip until that position? > > > > IOW, skipping text in at least some situation needs to skip multiple > > words, perhaps even multiple lines, and the skip function should be > > allowed to specify that in one go. Right? > > You are making too many assumptions about how the spell checker logic > works. What you propose would be really handy for ispell-region and the > like but is not usable by Flyspell -- for the same reason Flyspell > doesn't use ispell-skip-region-alist. This depends on where we decide to plug this feature into Flyspell, I think. If we plug this into it before it gets to process the result of flyspell-get-word, then all we need to do is make sure flyspell-get-word returns nil for stretches of text that need to be skipped. > We should come up with an API that any spell-checking package, present > of future, could use. I think what I proposed fits the bill. But it's just an idea. > >> jit-spell only uses ispell.el to start a process and jinx doesn't use it > >> at all. > > > > jinx is not in Emacs, so we don't have to solve its problems. And > > jit-spell uses ispell.el, so it will be able to use any function > > there. > > We don't need to solve jinx's problems, but the API should be convenient > for any third-party package to integrate with, and that's why I brought > up the example. I don't see how loading a single Lisp file could be of any inconvenience. Adding functions to preloaded packages just because we think they will make it convenient to some third-party package is not TRT.