Re: emacs/etc/images/gud record-start.xpm record-st... [EMACS_23_1_RC]

Re: emacs/etc/images/gud record-start.xpm record-st... [EMACS_23_1_RC]

[Glenn Morris]

Nick Roberts wrote:

> Added files:
> 	etc/images/gud : record-start.xpm record-stop.xpm 
> 	                 reverse-continue.xpm reverse-finish.xpm 
> 	                 reverse-next.xpm reverse-nexti.xpm 
> 	                 reverse-step.xpm reverse-stepi.xpm 


Could you update the README file accordingly, please? Thanks.

Also, AFAIK the EMACS_23_1_RC branch is not currently planned to be
used for Emacs 23.2, and there is no automatic syncing to the trunk,
so you might want to manually copy these changes there.

Re: emacs/etc/images/gud record-start.xpm record-st... [EMACS_23_1_RC]

[Nick Roberts]

Glenn Morris writes:
 > Nick Roberts wrote:
 > 
 > > Added files:
 > > 	etc/images/gud : record-start.xpm record-stop.xpm 
 > > 	                 reverse-continue.xpm reverse-finish.xpm 
 > > 	                 reverse-next.xpm reverse-nexti.xpm 
 > > 	                 reverse-step.xpm reverse-stepi.xpm 
 > 
 > 
 > Could you update the README file accordingly, please? Thanks.

Done.

 > Also, AFAIK the EMACS_23_1_RC branch is not currently planned to be
 > used for Emacs 23.2, and there is no automatic syncing to the trunk,
 > so you might want to manually copy these changes there.

These changes won't work on the trunk because gdb-ui.el has been replaced
by gdb-mi.el there (annotations replaced by GDB/MI).

I don't know what the plan is but past experience suggests that there will
be at least one bugfix release on this branch.  If that is not the case this
time, please consider this a request for such a release.

-- 
Nick                                           http://www.inet.net.nz/~nickrob

Re: emacs/etc/images/gud record-start.xpm record-st... [EMACS_23_1_RC]

[Eli Zaretskii]

> Date: Sat, 8 Aug 2009 17:00:14 +1200
> From: nickrob@snap.net.nz (Nick Roberts)
> Cc: Emacs developers <emacs-devel@gnu.org>
> 
> Glenn Morris writes:
>  > Nick Roberts wrote:
>  > 
>  > > Added files:
>  > > 	etc/images/gud : record-start.xpm record-stop.xpm 
>  > > 	                 reverse-continue.xpm reverse-finish.xpm 
>  > > 	                 reverse-next.xpm reverse-nexti.xpm 
>  > > 	                 reverse-step.xpm reverse-stepi.xpm 
>  > 
>  > 
>  > Could you update the README file accordingly, please? Thanks.
> 
> Done.

Thanks.

However, there's one more problem with these new XPM files: their
names clash in the 8+3 restricted namespace of DOS filesystems.

Can we please rename them to something that doesn't have this problem,
like recstart.xpm, recstop.xpm, rev-continue.xpm, etc.?

Re: emacs/etc/images/gud record-start.xpm record-st... [EMACS_23_1_RC]

[Nick Roberts]

 > However, there's one more problem with these new XPM files: their
 > names clash in the 8+3 restricted namespace of DOS filesystems.

Sorry, it's an issue I constantly forget.

 > Can we please rename them to something that doesn't have this problem,
 > like recstart.xpm, recstop.xpm, rev-continue.xpm, etc.?

Does rev-continue.xpm work with 8+3 DOS file names?  I thought it meant the
basename had only 8 characters (rev-continue has 12?).  I don't really mind
what they are called, or if you change them.  I'm willing to do it and I would
probably use the names in gud.el: recstart, recstop, rnext, rnexti, rstep,
rstepi, rfinish, rcont.  Are these okay?

-- 
Nick                                           http://www.inet.net.nz/~nickrob

Re: emacs/etc/images/gud record-start.xpm record-st... [EMACS_23_1_RC]

[Eli Zaretskii]

> Date: Sat, 8 Aug 2009 22:24:34 +1200
> Cc: rgm@gnu.org, emacs-devel@gnu.org
> From: nickrob@snap.net.nz (Nick Roberts)
> 
>  > Can we please rename them to something that doesn't have this problem,
>  > like recstart.xpm, recstop.xpm, rev-continue.xpm, etc.?
> 
> Does rev-continue.xpm work with 8+3 DOS file names?  I thought it meant the
> basename had only 8 characters (rev-continue has 12?).

No, the requirement is to have them _unique_ in the 8+3 characters.
Thus, rev-continue.xpm gets truncated to rev-cont.xpm, and if no other
file gets truncated to the same 8+3 name, it's fine.

The DOS port of Emacs does not support images, so these files won't be
used there, we just need to avoid problems when unpacking the tarball.
But even if Emacs did use these files on DOS, the filesystem calls
transparently truncate the file names to 8+3 limits, and will happily
resolve rev-continue.xpm to an existing rev-cont.xpm.

> I'm willing to do it and I would probably use the names in gud.el:
> recstart, recstop, rnext, rnexti, rstep, rstepi, rfinish, rcont.
> Are these okay?

Yes, they are okay.

Thanks.