From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: dash.el [was: Re: Imports / inclusion of s.el into Emacs] Date: Tue, 12 May 2020 18:58:23 -0400 Message-ID: <833A049F-5B0B-46C0-B670-9CA3F4684226@gmail.com> References: <35DBF02E-44D7-41E5-A217-7D6EC84ED221@icloud.com> <83d07984ux.fsf@gnu.org> <87y2pxcb85.fsf@russet.org.uk> <831rnp82rv.fsf@gnu.org> <87sgg4bzqg.fsf@russet.org.uk> Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Content-Type: multipart/alternative; boundary="Apple-Mail=_BE58D788-FC17-4DF5-92E0-ADAB353BA53F" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="55635"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rms@gnu.org, joostkremers@fastmail.fm, Emacs-devel@gnu.org, ams@gnu.org, monnier@iro.umontreal.ca, pcr910303@icloud.com, Eli Zaretskii To: Phillip Lord Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 13 00:59:00 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jYdrX-000ELD-Ko for ged-emacs-devel@m.gmane-mx.org; Wed, 13 May 2020 00:58:59 +0200 Original-Received: from localhost ([::1]:49602 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYdrW-0000yN-NE for ged-emacs-devel@m.gmane-mx.org; Tue, 12 May 2020 18:58:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49982) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYdr2-0000LV-P5 for Emacs-devel@gnu.org; Tue, 12 May 2020 18:58:28 -0400 Original-Received: from mail-qt1-x82f.google.com ([2607:f8b0:4864:20::82f]:33004) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jYdr1-0007HJ-Tr; Tue, 12 May 2020 18:58:28 -0400 Original-Received: by mail-qt1-x82f.google.com with SMTP id y42so9206904qth.0; Tue, 12 May 2020 15:58:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=4ggltBvQlGd7W5+YgRjebDFtH4n0CAHdqp1dJRjwuNo=; b=tIAZw7PKIHItRaQx76viGuhXLi9n76gk0uazUMCcPQecn+wc4vP0kvoq1lbwSklhln YvUo8pUNc+92klajRmGuQ4Bb3tb0/lXgps/vJ94/IZG/4FTJVJpk7ID1kf8Atq2Ioy5v 5VqlFGEoJIxoMVowAc7Y+VdCUjUX7MUHfnYgkuOnHbV/224qEguFFMJvqGitEq7drdf2 ToSmpxgVhKtq3fwPH4x00IYDnnIKgHH5XsLzA89zHjdxpHY/DL8W0vckvxMIJ+UijeY/ irazNcR/gSm/PCzOSFG7bRnxdRKWo6GnwojZREjm3mBI89fN6ppqu6TKAvkZKQmIjTSS mwRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=4ggltBvQlGd7W5+YgRjebDFtH4n0CAHdqp1dJRjwuNo=; b=CbmubqIjnlGxz9ezroOagggGntV6siQYsNEz7RGYjfMIiNJwGN2ssHXs6xVk2c4iSq hjQfdP7MzKRkLOnFfw+YnpgwSSdAVEMcLAnxLHhh8cLUlj91f8m+azEZ7OurCvyZ3CrF f23w1EmghVBi/JevAgkdYQ9tCZxChRv+3WochpuLwf6KN/zQjl0TztaG9aHewlIw4g3e /h3Ui9ePWxioeyoSF9e2M1g3MIL0xoTNY+JvNWOLmMoKm44sQsaa+sRK5MTje9GnjrFT FNA1UPy2osXhWY8JwxLbDLJ+CCiAAEGE986CsbN5XE7mNi+Fhpc23X5YfFmbENBl6BET fM9w== X-Gm-Message-State: AGi0PuZKDZb+ZqEBkZ/agmOMLI9Bd1EGRSZsx0CVR2RSVLinsC4cqw00 pQp0V1aCgdgI8gBefat3oZ8= X-Google-Smtp-Source: APiQypJq2N9MkVl4yIXzvX+vEdGLsati4QF1mLIy/rs1VPvIo8jfI6Sx32iK0wgyJmQgDYzEvRsSWw== X-Received: by 2002:ac8:4987:: with SMTP id f7mr23949500qtq.160.1589324305961; Tue, 12 May 2020 15:58:25 -0700 (PDT) Original-Received: from [192.168.1.5] (c-174-60-229-153.hsd1.pa.comcast.net. [174.60.229.153]) by smtp.gmail.com with ESMTPSA id 23sm12217972qkk.11.2020.05.12.15.58.24 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 May 2020 15:58:25 -0700 (PDT) In-Reply-To: <87sgg4bzqg.fsf@russet.org.uk> X-Mailer: Apple Mail (2.3608.80.23.2.2) Received-SPF: pass client-ip=2607:f8b0:4864:20::82f; envelope-from=casouri@gmail.com; helo=mail-qt1-x82f.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:250057 Archived-At: --Apple-Mail=_BE58D788-FC17-4DF5-92E0-ADAB353BA53F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On May 12, 2020, at 5:38 PM, Phillip Lord = wrote: >=20 >=20 > I understand why you worry about code quality, and this is valid. I > think most of Magnar's code has proven itself; the usage stats speak = for > themselves. If packages like this do not meet Emacs standards, = perhaps, > this it is Emacs standards that need to change to fit. >=20 Good code quality along doesn=E2=80=99t mean a package is suitable to be = added to Emacs core. One should also consider the tradition and the = overall style of the interface. E.g., how do you feel about having both = string-prefix-p and s-starts-with? in Emacs? If we have a set of good = string functions, should Clojure developers add them to their core? Yuan= --Apple-Mail=_BE58D788-FC17-4DF5-92E0-ADAB353BA53F Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

On May 12, 2020, at 5:38 PM, Phillip Lord <phillip.lord@russet.org.uk> wrote:


I understand why you worry about code quality, and this is = valid. I
think most of Magnar's code has proven itself; the usage = stats speak for
themselves. If packages like this do not meet Emacs = standards, perhaps,
this it is Emacs standards that need to change to = fit.


Good code quality along doesn=E2=80=99t mean = a package is suitable to be added to Emacs core. One should also = consider the tradition and the overall style of the interface. E.g., how = do you feel about having both string-prefix-p and s-starts-with? in = Emacs? If we have a set of good string functions, should Clojure = developers add them to their core?

Yuan
= --Apple-Mail=_BE58D788-FC17-4DF5-92E0-ADAB353BA53F--