From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Truncating scroll runs that copy to where we copied to Date: Sun, 20 Nov 2011 20:23:27 +0200 Message-ID: <8339dibqlc.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1321813531 29343 80.91.229.12 (20 Nov 2011 18:25:31 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 20 Nov 2011 18:25:31 +0000 (UTC) Cc: emacs-devel@gnu.org To: YAMAMOTO Mitsuharu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 20 19:25:27 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RSC50-0007N8-09 for ged-emacs-devel@m.gmane.org; Sun, 20 Nov 2011 19:25:26 +0100 Original-Received: from localhost ([::1]:52019 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RSC4z-0005LJ-Fw for ged-emacs-devel@m.gmane.org; Sun, 20 Nov 2011 13:25:25 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:35200) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RSC4w-0005LE-40 for emacs-devel@gnu.org; Sun, 20 Nov 2011 13:25:23 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RSC4u-0004Db-1F for emacs-devel@gnu.org; Sun, 20 Nov 2011 13:25:21 -0500 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:49063) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RSC4t-0004DA-Nf for emacs-devel@gnu.org; Sun, 20 Nov 2011 13:25:19 -0500 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0LUZ00E001M1B200@a-mtaout23.012.net.il> for emacs-devel@gnu.org; Sun, 20 Nov 2011 20:25:17 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([77.127.237.133]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LUZ00EAO1U23E80@a-mtaout23.012.net.il>; Sun, 20 Nov 2011 20:25:16 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.175 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:146100 Archived-At: > Date: Sun, 20 Nov 2011 16:13:59 +0900 > From: YAMAMOTO Mitsuharu > > I think that `scrolling_window' needs to truncate scroll runs that > copy to where we copied to; otherwise, `assign_row (to, from)' assigns > a previously disabled bogus row in the desired matrix when we have an > overlap in the copy destination. Such truncation can also avoid > unnecessary copy in the actual graphics operation. > > Could someone double-check the code below? Could you please elaborate on the rationale? Like, give a specific use case with a few rows in the current and desired matrix, and show why the current code does not DTRT? I'm not saying you are wrong (I have my doubts about portions of that function), just that we should at least look into a specific test case, even if simplified one, to make sure we are fixing a real bug. TIA