From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: call for more ert tests Date: Tue, 25 Jun 2013 21:53:01 +0300 Message-ID: <8338s6hvjm.fsf@gnu.org> References: <838v1zjrnl.fsf@gnu.org> <22873922.rILsHsxLja@descartes> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE X-Trace: ger.gmane.org 1372186403 19992 80.91.229.3 (25 Jun 2013 18:53:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 25 Jun 2013 18:53:23 +0000 (UTC) Cc: emacs-devel@gnu.org To: =?utf-8?Q?R=C3=BCdiger?= Sonderfeld Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 25 20:53:23 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UrYMj-0006ea-Bq for ged-emacs-devel@m.gmane.org; Tue, 25 Jun 2013 20:53:21 +0200 Original-Received: from localhost ([::1]:48818 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrYMi-0001zW-W4 for ged-emacs-devel@m.gmane.org; Tue, 25 Jun 2013 14:53:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42871) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrYMd-0001zK-Rd for emacs-devel@gnu.org; Tue, 25 Jun 2013 14:53:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UrYMa-0007oH-1A for emacs-devel@gnu.org; Tue, 25 Jun 2013 14:53:15 -0400 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:57124) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrYMZ-0007nJ-Ot; Tue, 25 Jun 2013 14:53:11 -0400 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0MOY00700PS9T000@a-mtaout23.012.net.il>; Tue, 25 Jun 2013 21:53:10 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MOY0076BPSLSY00@a-mtaout23.012.net.il>; Tue, 25 Jun 2013 21:53:10 +0300 (IDT) In-reply-to: <22873922.rILsHsxLja@descartes> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.175 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:161039 Archived-At: > From: R=C3=BCdiger Sonderfeld > Cc: Glenn Morris > Date: Tue, 25 Jun 2013 19:18:25 +0200 >=20 > But a real test coverage would require tests for the rendered=20 > layout. Which would be hard to write and even worse probably break= ing all the=20 > time when rendering is improved and thus the output changes. The fact that the "correct" results change with development is a fact of life in every project, not just in Emacs. It is detected very simply, when the test fails. Then you analyze the failure, understan= d that the expected results are wrong, and modify them to follow suit. Case closed. > Therefore having a policy to demand tests for new features might be= counter=20 > productive. On the other hand maintainers should at least ask for = test cases=20 > when they think a new feature could benefit from tests. Which in m= y=20 > experience, as somebody who is relatively new to contributing to Em= acs, does=20 > not seem to happen at all. If you don't have good test coverage, you cannot regress-test, so you can never be sure that a change you just made doesn't break something= . It's as simple as that, and I'm sure you know it.