unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Glenn Morris <rgm@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: MinGW "pwd -W" configure.ac correction
Date: Thu, 24 Oct 2013 19:25:52 +0300	[thread overview]
Message-ID: <8338nqiqjz.fsf@gnu.org> (raw)
In-Reply-To: <nsbo2flgyb.fsf@fencepost.gnu.org>

> From: Glenn Morris <rgm@gnu.org>
> cc: emacs-devel@gnu.org
> Date: Wed, 23 Oct 2013 19:12:44 -0400
> 
> 
> I think that (thanks to me) there's an issue with the
> 
>   test "$MSYSTEM" = "MINGW32" && abs_srcdir=`(cd "$abs_srcdir"; pwd -W | sed -e 's,^\([[A-Za-z]]\):,/\1,')`
> 
> stuff in configure.
> 
> Unlike $srcdir (which this used to use), it seems that $abs_srcdir it
> not set at this stage in configure. Instead it only gets set by
> config.status (IIUC).
> 
> Does this `pwd -W' correction only matter for epaths.h?
> If so, could it be moved to the epaths-force-w32 rule in Makefile.in?

This could maybe work today, but it's a time bomb: the underlying
problem, explained in configure.ac, will bite us if we ever invoke any
MinGW program (including, but not limited to, Emacs) during the build.
So it is best to get that problem out of our way as soon as possible.

> That rule already does some correcting of paths.

Those are different problems.

> Or does every instance of $abs_srcdir in all the Makefiles need correcting?

We cannot allow something like /usr/foo/bar in $abs_srcdir, anywhere.
It must be in the /x/foo/bar format, i.e. it must include the Windows
drive letter (in the "/x/" form) explicitly.  It's just that epaths.h
were the first place where this problem hit us.

> If so, we'll have a find way to make config.status do it
> (AC_CONFIG_COMMANDS?)...

How can we be sure that the same problem won't happen while the
configure script itself runs, before it invokes config.status?



  parent reply	other threads:[~2013-10-24 16:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-23 23:12 MinGW "pwd -W" configure.ac correction Glenn Morris
2013-10-23 23:37 ` Glenn Morris
2013-10-24  0:12   ` Glenn Morris
2013-10-24  2:40     ` Glenn Morris
2013-10-24 12:39       ` Óscar Fuentes
2013-10-24 16:25 ` Eli Zaretskii [this message]
2013-10-25  1:55   ` Glenn Morris
2013-10-24 17:13 ` Achim Gratz
2013-10-24 18:15   ` Eli Zaretskii
2013-10-24 19:54     ` Achim Gratz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8338nqiqjz.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).