From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org
Subject: Re: Changes in update-game-score.c
Date: Thu, 23 Jan 2014 05:52:29 +0200 [thread overview]
Message-ID: <8338kffj7m.fsf@gnu.org> (raw)
In-Reply-To: <52E08D31.3080801@cs.ucla.edu>
> Date: Wed, 22 Jan 2014 19:32:01 -0800
> From: Paul Eggert <eggert@cs.ucla.edu>
> CC: emacs-devel@gnu.org
>
> Eli Zaretskii wrote:
> > Why do we suddenly care about it so much?
>
> We got a bug report about it, which I fixed, and I noticed some other
> bugs in the neighborhood, including undefined behavior and race
> conditions which are dicey in a setuid program (it's bad PR at the very
> least). A feature freeze shouldn't prevent us from fixing such bugs.
The bugfix should have fixed the bug that was reported, and that's it.
Even the first bugfix was already too much (you said it yourself:
fancy). The rest is just superfluous and unneeded, as the program is
not important enough for us to waste any time on it. (Why isn't it
implemented in Lisp, anyway?)
> The main culprit here was the w32 port's definition of fchmod as a noop
> for Emacs, and its failure to define fchmod for non-Emacs executables.
> We can't expect non-w32 experts to anticipate that sort of tricky
> situation flawlessly every time.
No one requested you to be the expert, you are missing the point.
You never explained why the switch from chmod to fchmod was needed
anyway. Do we really care about race conditions here? What, the same
user will be updating her score simultaneously from 2 sessions? Come
on!
Feature freeze means restraint: do not try to "fix" that which has
been happily "broken" for ages.
next prev parent reply other threads:[~2014-01-23 3:52 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-22 19:42 Changes in update-game-score.c Eli Zaretskii
2014-01-22 19:50 ` David Kastrup
2014-01-22 20:07 ` Eli Zaretskii
2014-01-22 20:10 ` David Kastrup
2014-01-23 1:51 ` Glenn Morris
2014-01-23 3:33 ` Paul Eggert
2014-01-23 3:53 ` Eli Zaretskii
2014-01-23 16:02 ` Eli Zaretskii
2014-01-23 3:58 ` Glenn Morris
2014-01-23 3:32 ` Paul Eggert
2014-01-23 3:52 ` Eli Zaretskii [this message]
2014-01-23 3:59 ` Glenn Morris
2014-01-23 4:30 ` Glenn Morris
2014-01-23 4:33 ` Glenn Morris
2014-01-23 4:56 ` Paul Eggert
2014-01-23 16:07 ` Eli Zaretskii
2014-01-23 18:18 ` Paul Eggert
2014-01-23 20:27 ` Juanma Barranquero
2014-01-23 21:50 ` Paul Eggert
2014-01-23 22:39 ` Juanma Barranquero
2014-01-24 7:34 ` Eli Zaretskii
2014-01-24 8:42 ` Paul Eggert
2014-01-24 9:17 ` Eli Zaretskii
2014-01-24 15:29 ` Jarek Czekalski
2014-01-24 15:40 ` Eli Zaretskii
2014-01-24 15:42 ` change the Subject line when you change topics [was: Changes in update-game-score.c] Drew Adams
2014-01-25 10:00 ` Jarek Czekalski
2014-01-24 16:43 ` Patches with independent changes Paul Eggert
2014-01-24 21:39 ` Eli Zaretskii
2014-01-24 22:34 ` Paul Eggert
2014-01-25 7:22 ` Eli Zaretskii
2014-01-25 17:01 ` Paul Eggert
2014-01-25 17:22 ` Eli Zaretskii
2014-01-25 17:25 ` Eli Zaretskii
2014-01-25 20:58 ` Paul Eggert
2014-01-26 3:47 ` Eli Zaretskii
2014-01-26 7:41 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8338kffj7m.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).