From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Trunk emacs infelicity with linum mode Date: Sun, 07 Sep 2014 22:28:54 +0300 Message-ID: <8338c3cjrd.fsf@gnu.org> References: <87zjeix7hg.fsf@glaurung.internal.golden-gryphon.com> <838um1gar9.fsf@gnu.org> <87ppfdyhpf.fsf@glaurung.internal.golden-gryphon.com> <8361h5g7mv.fsf@gnu.org> <87zjehw5cs.fsf@glaurung.internal.golden-gryphon.com> <834mwog0u0.fsf@gnu.org> <87wq9kd5y3.fsf@glaurung.internal.golden-gryphon.com> <83oauve75i.fsf@gnu.org> <87lhpxaopi.fsf@glaurung.internal.golden-gryphon.com> <83vbp1deta.fsf@gnu.org> <540ACB6A.5020402@gmx.at> <540AED8A.9030000@gmx.at> <83ha0jcv31.fsf@gnu.org> <540C9DEF.1010301@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1410118151 28166 80.91.229.3 (7 Sep 2014 19:29:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 7 Sep 2014 19:29:11 +0000 (UTC) Cc: srivasta@ieee.org, emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 07 21:29:03 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XQi90-00036E-Nr for ged-emacs-devel@m.gmane.org; Sun, 07 Sep 2014 21:29:02 +0200 Original-Received: from localhost ([::1]:39386 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQi90-0007v2-BE for ged-emacs-devel@m.gmane.org; Sun, 07 Sep 2014 15:29:02 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37789) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQi8t-0007uu-Gy for emacs-devel@gnu.org; Sun, 07 Sep 2014 15:29:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XQi8o-0002d6-LS for emacs-devel@gnu.org; Sun, 07 Sep 2014 15:28:55 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:38383) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQi8o-0002cv-D0 for emacs-devel@gnu.org; Sun, 07 Sep 2014 15:28:50 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NBJ00800Q383A00@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Sun, 07 Sep 2014 22:28:49 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NBJ007BAQ40QZ50@a-mtaout22.012.net.il>; Sun, 07 Sep 2014 22:28:49 +0300 (IDT) In-reply-to: <540C9DEF.1010301@gmx.at> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.172 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:174069 Archived-At: > Date: Sun, 07 Sep 2014 20:03:27 +0200 > From: martin rudalics > CC: srivasta@ieee.org, emacs-devel@gnu.org > > > Yes, but how does that help us resolve this problem? There's nothing > > wrong in general with calling face-font, so linum-mode doesn't do > > anything blatantly incorrect here. It's just that this function is > > called "too early" in the frame creation process. > > At the time `window-configuration-change-hook' is called, the frame is > considered "official" already. Do you really want to wait calling it > until redisplay has passed over the frame at least once? Redisplay is not the issue here; non-basic faces are. See below. > > How about adding some simple flag that would avoid calling > > window-configuration-change-hook when adjust_frame_size is called from > > x-create-frame? > > There is such a flag: f->official. It does exactly that for all > adjust_frame_size calls before the last one that causes trouble. But if > we don't run `window-configuration-change-hook' here, we might not run > it at all when creating a new frame. f->official only means that the basic faces were realized; all the other faces are not realized yet. So if you want that flag to be it, we will have to make sure all the faces are realized before we set that flag. I believe the faces are realized in face-set-after-frame-default.