From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: fix/ert-multiline-explanation Date: Mon, 26 Oct 2015 17:57:19 +0200 Message-ID: <8337wxd3mo.fsf@gnu.org> References: <871tco2brx.fsf@russet.org.uk> <83a8r8wbcq.fsf@gnu.org> <87h9lehuvj.fsf@russet.org.uk> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1445875055 20936 80.91.229.3 (26 Oct 2015 15:57:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 26 Oct 2015 15:57:35 +0000 (UTC) Cc: emacs-devel@gnu.org To: phillip.lord@russet.org.uk (Phillip Lord) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 26 16:57:21 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zqk98-0006Cv-Nf for ged-emacs-devel@m.gmane.org; Mon, 26 Oct 2015 16:57:18 +0100 Original-Received: from localhost ([::1]:53659 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zqk98-0000Bt-1y for ged-emacs-devel@m.gmane.org; Mon, 26 Oct 2015 11:57:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39604) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zqk93-0000Bc-RS for emacs-devel@gnu.org; Mon, 26 Oct 2015 11:57:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zqk8z-0000gn-Qy for emacs-devel@gnu.org; Mon, 26 Oct 2015 11:57:13 -0400 Original-Received: from mtaout21.012.net.il ([80.179.55.169]:43429) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zqk8z-0000gZ-Ir for emacs-devel@gnu.org; Mon, 26 Oct 2015 11:57:09 -0400 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0NWU00B0045QTW00@a-mtaout21.012.net.il> for emacs-devel@gnu.org; Mon, 26 Oct 2015 17:57:07 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NWU00BAN4B7OT70@a-mtaout21.012.net.il>; Mon, 26 Oct 2015 17:57:07 +0200 (IST) In-reply-to: <87h9lehuvj.fsf@russet.org.uk> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:192660 Archived-At: > From: phillip.lord@russet.org.uk (Phillip Lord) > Cc: > Date: Mon, 26 Oct 2015 08:55:12 +0000 > > F with > (ert-test-failed > ((should > (silly-predicate > (advice-add 'ert--pp-with-indentation-and-newline :around #'sisyphus--ert-pp-with-indentation-and-newline))) > :form > (silly-predicate nil) > :value nil :explanation "Silly predicate is silly. > I mean, it's in the name, so why are you using it? > It's never going to return a sensible answer. > It is after silly. > ^^^^^")) > > F without > (ert-test-failed > ((should > (silly-predicate > (advice-remove 'ert--pp-with-indentation-and-newline #'sisyphus--ert-pp-with-indentation-and-newline))) > :form > (silly-predicate nil) > :value nil :explanation "Silly predicate is silly.\nI mean, it's in the name, so why are you using it?\nIt's never going to return a sensible answer.\nIt is after silly.\n ^^^^^")) Looks like your change is a clear improvement, so please install. Thanks.