From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: ofv@wanadoo.es, emacs-devel@gnu.org
Subject: Re: emacs-25 3722a69: Fix bugs in window resizing code
Date: Wed, 02 Mar 2016 17:54:09 +0200 [thread overview]
Message-ID: <8337s87u5a.fsf@gnu.org> (raw)
In-Reply-To: <56D6A2DA.4080208@gmx.at> (message from martin rudalics on Wed, 02 Mar 2016 09:22:50 +0100)
> Date: Wed, 02 Mar 2016 09:22:50 +0100
> From: martin rudalics <rudalics@gmx.at>
> CC: ofv@wanadoo.es, emacs-devel@gnu.org
>
> (1) Don't make this function throw an error when a window cannot be made
> as large as requested but try to make the window as large as possible.
> This was the state before my last change. Its major disadvantage is
> that enlarging the window may fail silently which makes this differ from
> most other window commands. And, obviously no code can rely on this
> function to behave predictably either.
>
> (2) Have this function throw an error when a window cannot be made as
> large as requested. This is the present state. Its major disadvantage
> is that packages could rely on this function to never throw an error
> except for a short period in 2011. Even if we manage to fix all
> occurrences in the emacs-25 code base, there might be still packages in
> the wild that count on the "silent" behavior.
>
> (3) Have this function throw an error in interactive use as in (1) and
> behave as (2) in non-interactive use. The disadvantage of this approach
> is that, strictly spoken, we would have to document this function again
> in the Elisp manual, describe its different behaviors and support it
> until further notice.
>
> We have to decide what to do for emacs-25.
Thanks for this clear summary.
If (3) can be done easily and reliably, I think it's the best
alternative. That it might need documentation changes shouldn't
frighten us.
next prev parent reply other threads:[~2016-03-02 15:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160218102715.15576.42604@vcs.savannah.gnu.org>
[not found] ` <E1aWLnn-000448-7K@vcs.savannah.gnu.org>
2016-03-01 1:31 ` emacs-25 3722a69: Fix bugs in window resizing code Óscar Fuentes
2016-03-01 8:07 ` martin rudalics
2016-03-01 15:10 ` Óscar Fuentes
2016-03-01 17:04 ` martin rudalics
2016-03-01 17:20 ` Eli Zaretskii
2016-03-02 8:22 ` martin rudalics
2016-03-02 9:28 ` martin rudalics
2016-03-02 15:54 ` Eli Zaretskii [this message]
2016-03-04 7:48 ` martin rudalics
2016-03-04 8:28 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8337s87u5a.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=ofv@wanadoo.es \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).