unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stephen Berman <stephen.berman@gmx.net>
Cc: emacs-devel@gnu.org
Subject: Re: todo-mode doc bug
Date: Wed, 27 Apr 2016 11:50:02 +0300	[thread overview]
Message-ID: <8337q7zb9h.fsf@gnu.org> (raw)
In-Reply-To: <87r3drv4yc.fsf@gmx.net> (message from Stephen Berman on Wed, 27 Apr 2016 10:19:55 +0200)

> From: Stephen Berman <stephen.berman@gmx.net>
> Cc: emacs-devel@gnu.org
> Date: Wed, 27 Apr 2016 10:19:55 +0200
> 
> >> There is no outstanding bug about this; my question was about whether it
> >> is necessary to file one for this doc string change
> >
> > No need.  However, mentioning in the commit log the URL for the
> > discussion of the issue should be considered.
> 
> This thread is the only discussion of this issue, so in the hope that
> you agree with me that it isn't relevant to the doc bug per se and hence
> wouldn't be appropriate to reference in the commit message, I've gone
> ahead and committed the fix without such a reference.

I often wonder why people need to assume something about what others
think, instead of just asking them and waiting for an answer.  What's
the rush?

As it happens, I don't agree.  In this message:

  http://lists.gnu.org/archive/html/emacs-devel/2016-04/msg00738.html

you say more about the rationale for the fix than in the log message
for the commit you just made:

  Specifically, I noticed that the doc string of
  `todo-show' is in part obsolete and incorrect -- in fact, it already was
  when I initially committed this version of todo-mode to the Emacs
  repository, because I had failed to update the doc string after making
  the change in ea3ae33b5b94bf095c52f279887009e8fb71a9df prior to the
  initial commit.  (In contrast, the Todo mode Info manual contains the
  correct information.)

Admittedly, I'm close to splitting hair here, but the references to a
previous commit and to the manual are valuable and relevant
information.

That's why I generally advise to abandon doubt and simply include the
reference in the log message, as no real harm could ever be done by
doing that.

Thanks.



  reply	other threads:[~2016-04-27  8:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20160326221513.15789.84807@vcs.savannah.gnu.org>
     [not found] ` <E1ajwUD-000485-9x@vcs.savannah.gnu.org>
2016-03-26 23:17   ` [Emacs-diffs] emacs-25 e5c17f4: Fix todo-mode category movement John Wiegley
2016-03-26 23:51     ` Stephen Berman
2016-04-03 18:22       ` John Wiegley
2016-04-25  9:56         ` todo-mode doc bug (was: [Emacs-diffs] emacs-25 e5c17f4: Fix todo-mode category movement) Stephen Berman
2016-04-25 10:03           ` Eli Zaretskii
2016-04-25 10:18             ` todo-mode doc bug Stephen Berman
2016-04-25 10:23               ` Eli Zaretskii
2016-04-27  8:19                 ` Stephen Berman
2016-04-27  8:50                   ` Eli Zaretskii [this message]
2016-04-27  9:22                     ` Stephen Berman
2016-04-27  9:52                       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8337q7zb9h.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=stephen.berman@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).