From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Unbalanced change hooks (part 2) [Documentation fix still remaining] Date: Tue, 30 Aug 2016 18:51:39 +0300 Message-ID: <8337lmntkk.fsf@gnu.org> References: <83h9ashfgx.fsf@gnu.org> <831t1wharr.fsf@gnu.org> <20160810161821.GB3413@acm.fritz.box> <83wpjofttf.fsf@gnu.org> <20160810185735.GD3413@acm.fritz.box> <20160811112951.GA2154@acm.fritz.box> <7e1478b6-cf00-fcbf-8c24-43bdaa57e2b6@dancol.org> <415d1cca-f32c-624e-a4be-9aadcf8a0f17@dancol.org> <8cea494d-33e0-0a7d-2bd0-c8bfb9f597aa@dancol.org> <8760qie4f4.fsf@russet.org.uk> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1472572361 17584 195.159.176.226 (30 Aug 2016 15:52:41 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 30 Aug 2016 15:52:41 +0000 (UTC) Cc: dancol@dancol.org, monnier@IRO.UMontreal.CA, emacs-devel@gnu.org To: phillip.lord@russet.org.uk (Phillip Lord) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 30 17:52:33 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1belKy-0003oJ-Se for ged-emacs-devel@m.gmane.org; Tue, 30 Aug 2016 17:52:33 +0200 Original-Received: from localhost ([::1]:49790 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1belKw-00066s-GG for ged-emacs-devel@m.gmane.org; Tue, 30 Aug 2016 11:52:30 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42063) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1belKG-00063v-69 for emacs-devel@gnu.org; Tue, 30 Aug 2016 11:51:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1belKC-0003ag-0y for emacs-devel@gnu.org; Tue, 30 Aug 2016 11:51:47 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56010) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1belKB-0003aT-TX; Tue, 30 Aug 2016 11:51:43 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1736 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1belKA-0005Hu-1N; Tue, 30 Aug 2016 11:51:42 -0400 In-reply-to: <8760qie4f4.fsf@russet.org.uk> (phillip.lord@russet.org.uk) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:206950 Archived-At: > From: phillip.lord@russet.org.uk (Phillip Lord) > Date: Tue, 30 Aug 2016 15:07:27 +0100 > Cc: Daniel Colascione , emacs-devel@gnu.org > > So having them balanced and consistent would be nice. I agree that in > fixing this, bad things might happens. But surely that is a risk of > fiddling with any core part of Emacs. One response would be to not to > it. Another response would be to incrementally increase the number of > test cases Emacs has to enable this (and other) changes in the core to > be made with more confidence. My response is that we should not do it until we have decent test coverage of the insdel functionality. I simply don't believe in our ability to avoid breakage in this core functionality unless we have good test coverage. Been there, done that, have bruises to prove it.