From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Old-style backquotes Date: Sun, 08 Oct 2017 19:05:53 +0300 Message-ID: <83376ttyji.fsf@gnu.org> References: <46860d72-9c7e-2c80-5fe3-e17f5ccd6e2d@cs.ucla.edu> <83h8vg1dhy.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1507478809 24610 195.159.176.226 (8 Oct 2017 16:06:49 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 8 Oct 2017 16:06:49 +0000 (UTC) Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org To: Philipp Stephani Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 08 18:06:45 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1E6G-0005rO-T7 for ged-emacs-devel@m.gmane.org; Sun, 08 Oct 2017 18:06:45 +0200 Original-Received: from localhost ([::1]:54310 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1E6O-0002a2-DH for ged-emacs-devel@m.gmane.org; Sun, 08 Oct 2017 12:06:52 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37766) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1E5Z-0002XU-KU for emacs-devel@gnu.org; Sun, 08 Oct 2017 12:06:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e1E5W-0008RO-IB for emacs-devel@gnu.org; Sun, 08 Oct 2017 12:06:01 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40128) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1E5W-0008RC-Ez; Sun, 08 Oct 2017 12:05:58 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4085 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e1E5V-00069s-Uc; Sun, 08 Oct 2017 12:05:58 -0400 In-reply-to: (message from Philipp Stephani on Sun, 08 Oct 2017 14:58:45 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219256 Archived-At: > From: Philipp Stephani > Date: Sun, 08 Oct 2017 14:58:45 +0000 > Cc: emacs-devel@gnu.org > > OK, here's a patch. Thanks, a few minor comments: > @@ -3178,10 +3171,7 @@ read1 (Lisp_Object readcharfun, int *pch, bool first_in_list) > first_in_list exception (old-style can still be obtained via > "(\`" anyway). */ > if (!new_backquote_flag && first_in_list && next_char == ' ') > - { > - Vlread_old_style_backquotes = Qt; > - goto default_label; > - } > + load_error_old_style_backquotes (); Here (and elsewhere) the indentation should be fixed to be in line with our style. > --- a/test/src/lread-tests.el > +++ b/test/src/lread-tests.el > @@ -173,13 +173,13 @@ lread-tests--last-message > (should (string-suffix-p "/somelib.el" (caar load-history))))) > > (ert-deftest lread-tests--old-style-backquotes () > - "Check that loading warns about old-style backquotes." > + "Check that loading doesn’t accept old-style backquotes." Please don't use literal curved quotes in doc strings and message text, they will be transformed (by default) when displayed.