From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: wait_reading_process_ouput hangs in certain cases (w/ patches) Date: Tue, 13 Mar 2018 18:12:22 +0200 Message-ID: <833714rm3d.fsf@gnu.org> References: <03261534-6bf5-1a5d-915f-d3c55aaa35e9@binary-island.eu> <206ebefa-7583-f049-140c-c8fd041b0719@cs.ucla.edu> <709614e8-1937-07c1-f554-b453ed4f3d4a@binary-island.eu> <7550438b-9fd4-d374-e571-8bb16456cad5@cs.ucla.edu> <797d0e16-1bae-50c2-35f8-05489ffce935@binary-island.eu> <83tvugdiu5.fsf@gnu.org> <877er5s0xv.fsf@gmail.com> <4e4c72bb-295d-81e1-e4ed-cad256bca83c@binary-island.eu> <87zi3v9461.fsf@gmail.com> <87k1uy8x68.fsf@gmail.com> <6d1970af-8c5c-20ba-be09-0b9aa757d663@binary-island.eu> <13b3e003-d12b-33a7-3ebe-c07b017a7cc0@binary-island.eu> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1520958343 31500 195.159.176.226 (13 Mar 2018 16:25:43 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 13 Mar 2018 16:25:43 +0000 (UTC) Cc: larsi@gnus.org, rrandresf@gmail.com, emacs-devel@gnu.org, eggert@cs.ucla.edu To: Matthias Dahl Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 13 17:25:39 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1evmk6-00084C-VN for ged-emacs-devel@m.gmane.org; Tue, 13 Mar 2018 17:25:39 +0100 Original-Received: from localhost ([::1]:41043 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evmm9-0000L0-WB for ged-emacs-devel@m.gmane.org; Tue, 13 Mar 2018 12:27:46 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57463) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evmXC-0004e9-JA for emacs-devel@gnu.org; Tue, 13 Mar 2018 12:12:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1evmX8-0000Yz-J8 for emacs-devel@gnu.org; Tue, 13 Mar 2018 12:12:18 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37542) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evmX8-0000Yv-FB; Tue, 13 Mar 2018 12:12:14 -0400 Original-Received: from [176.228.60.248] (port=4376 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1evmX7-0005SI-Qj; Tue, 13 Mar 2018 12:12:14 -0400 In-reply-to: <13b3e003-d12b-33a7-3ebe-c07b017a7cc0@binary-island.eu> (message from Matthias Dahl on Tue, 13 Mar 2018 10:54:00 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:223695 Archived-At: > Cc: andrés ramírez , > eggert@cs.ucla.edu, Eli Zaretskii , emacs-devel@gnu.org > From: Matthias Dahl > Date: Tue, 13 Mar 2018 10:54:00 +0100 > > @Eli: Those patches are, imho, clearly Emacs 26 material as well. And > along those lines, and I don't mean to be pushy at all :), I would like > to bring up the wait_reading_process_output fixes as well. I still think > it would be a good idea to get those into Emacs 26. I don't think it makes sense to put this on the emacs-26 branch, sorry. I even have evidence: the fact that one of the hunks re-introduced a previously solved bug, as pointed out by Robert. This code is very delicate and very central to Emacs operation. It's very easy to break Emacs subtly by seemingly-innocent changes in that area. We really need to test it much more than a few weeks before we are confident enough it is bug-free. The master branch is where such changes should be tested.