From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Some vars now limited to fixnum size. (Was: Merging bignum to master) Date: Mon, 20 Aug 2018 21:00:12 +0300 Message-ID: <8336v8ex5f.fsf@gnu.org> References: <877ekwu1mn.fsf@tromey.com> <611579fd-52f2-0104-ef82-a7a4a3929700@cs.ucla.edu> <878t51t32a.fsf_-_@red-bean.com> <28fcabff-d102-d67f-442f-f59eab5040c9@cs.ucla.edu> <31ba6457-6428-efc7-8423-1d6134c8e747@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1534787950 4626 195.159.176.226 (20 Aug 2018 17:59:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 20 Aug 2018 17:59:10 +0000 (UTC) Cc: kfogel@red-bean.com, tom@tromey.com, pipcet@gmail.com, emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 20 19:59:05 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1froSE-00012J-F2 for ged-emacs-devel@m.gmane.org; Mon, 20 Aug 2018 19:59:02 +0200 Original-Received: from localhost ([::1]:48479 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1froUL-0006xf-0X for ged-emacs-devel@m.gmane.org; Mon, 20 Aug 2018 14:01:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34380) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1froTd-0006xF-90 for emacs-devel@gnu.org; Mon, 20 Aug 2018 14:00:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1froTZ-0006iv-6F for emacs-devel@gnu.org; Mon, 20 Aug 2018 14:00:29 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39562) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1froTV-0006bn-6G; Mon, 20 Aug 2018 14:00:23 -0400 Original-Received: from [176.228.60.248] (port=2637 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1froTP-00080t-Iz; Mon, 20 Aug 2018 14:00:17 -0400 In-reply-to: <31ba6457-6428-efc7-8423-1d6134c8e747@cs.ucla.edu> (message from Paul Eggert on Mon, 20 Aug 2018 10:27:34 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228757 Archived-At: > From: Paul Eggert > Date: Mon, 20 Aug 2018 10:27:34 -0700 > Cc: tom@tromey.com, Pip Cet , emacs-devel@gnu.org > > + if (FIXNUMP (n)) > + num = XFIXNUM (n); > + else > + { > + num = mpz_sgn (XBIGNUM (n)->value); > + if (0 < num) > + num = EMACS_INT_MAX; /* LIST cannot possibly be this long. */ So we now silently replace the argument with another, smaller value, and then go ahead as if business as usual? Is that a good, user-friendly behavior?