From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Replace trivial pcase occurrences in the Emacs sources Date: Wed, 24 Oct 2018 21:32:12 +0300 Message-ID: <8336svryab.fsf@gnu.org> References: <20151216202605.GA3752@acm.fritz.box> <871t9yk98g.fsf@fencepost.gnu.org> <568936F0.3060505@yandex.ru> <87wprqitj5.fsf@fencepost.gnu.org> <56893C8C.3060200@yandex.ru> <87oad2irtd.fsf@fencepost.gnu.org> <5689456A.1010601@yandex.ru> <87egdy8tyz.fsf@fencepost.gnu.org> <56895FDE.4060406@yandex.ru> <8760za8r4a.fsf@fencepost.gnu.org> <87h9iunkcg.fsf@web.de> <87h8hc4xw2.fsf_-_@web.de> <83tvlcsnee.fsf@gnu.org> <87pnw037ar.fsf@web.de> <83ftwvs7y9.fsf@gnu.org> <877ei7mkfh.fsf@web.de> <83d0rzs680.fsf@gnu.org> <8736svmjkt.fsf@web.de> <83a7n3s0xf.fsf@gnu.org> <87in1rkz5b.fsf@web.de> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1540405877 1477 195.159.176.226 (24 Oct 2018 18:31:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 24 Oct 2018 18:31:17 +0000 (UTC) Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Michael Heerdegen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 24 20:31:12 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFNw0-0000H6-5L for ged-emacs-devel@m.gmane.org; Wed, 24 Oct 2018 20:31:12 +0200 Original-Received: from localhost ([::1]:49801 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gFNy6-0002Fl-3G for ged-emacs-devel@m.gmane.org; Wed, 24 Oct 2018 14:33:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52691) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gFNxM-0002BD-9N for emacs-devel@gnu.org; Wed, 24 Oct 2018 14:32:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gFNx9-0002DN-8v for emacs-devel@gnu.org; Wed, 24 Oct 2018 14:32:31 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52479) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gFNx3-00026V-IS; Wed, 24 Oct 2018 14:32:18 -0400 Original-Received: from [176.228.60.248] (port=2335 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gFNx1-0000oW-0E; Wed, 24 Oct 2018 14:32:15 -0400 In-reply-to: <87in1rkz5b.fsf@web.de> (message from Michael Heerdegen on Wed, 24 Oct 2018 19:55:28 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230641 Archived-At: > From: Michael Heerdegen > Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org > Date: Wed, 24 Oct 2018 19:55:28 +0200 > > > And if repeating (eq foo 'bar) is the issue, you can use assoc and a > > data structure, see my other message. Just a thought. > > That won't do it: pcase (or cl-case) clauses specify expressions to > evaluate instead of only values to return. Only those pcase forms that > have no side effects could be transformed into such an cdr-assoc > combination. Yes, but there are gobs of those.