From: Eli Zaretskii <eliz@gnu.org>
To: Alex Gramiak <agrambot@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Removing the usage of X structures (or their names) in independent code
Date: Thu, 09 May 2019 20:12:03 +0300 [thread overview]
Message-ID: <8336lnh7rw.fsf@gnu.org> (raw)
In-Reply-To: <87woizd263.fsf@gmail.com> (message from Alex Gramiak on Thu, 09 May 2019 10:26:44 -0600)
> From: Alex Gramiak <agrambot@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Thu, 09 May 2019 10:26:44 -0600
>
> > Why do you prefer a union? It uglifies the code and makes it harder
> > to read and understand. OTOH, having a backend-independent type (what
> > you call "typedef") is much cleaner.
>
> The union approach would be more future-proof (if the goal of multiple
> backends at once is realized), and I find it neater than having
> different types per backend. I would consider the union approach as
> having a "backend-independent type"; in the union approach, all backends
> of Emacs would have that union as the type, whereas in the typedef
> approach each backend pastes its own type into the generic parts of the
> code.
>
> The above goal is still far away, so it wouldn't be terrible to use
> typedefs in the interim.
Yes, I'd prefer not to make changes that are needed by future far-away
goals, especially when those changes makes the code less readable.
> > If that new structure is defined as (for example)
> >
> > typedef XColor EColor;
> >
> > then there's no overhead at all: you could simply assign an EColor to
> > XColor or even use the former directly in APIs that want the latter.
>
> Right, I meant overhead in the case of defining a new structure rather
> than defining a new name for the structure. For example:
>
> struct EColor
> {
> uint16_t red;
> uint16_t blue;
> uint16_t green;
> uint16_t alpha; /* Who knows, maybe? */
> unsigned long long pixel;
> };
>
> Which would need to be converted to XColor on the X backend.
But that's not needed if you use typedef as above for X. And for
non-X platforms we already have a definition of XColor, which just
needs to be renamed to EColor.
> > For more complex situations, see what we do with 'struct font' and
> > 'struct FOOfont' for font backend FOO.
>
> Could you point me to somewhere specific for this? I'm unsure to what
> you're referring.
For example, in ftfont.h:
struct font_info
{
struct font font;
#ifdef HAVE_LIBOTF
bool maybe_otf; /* Flag to tell if this may be OTF or not. */
OTF *otf;
#endif /* HAVE_LIBOTF */
FT_Size ft_size;
int index;
[...]
}
And an example how this is used in xftfont.c:
static int
xftfont_draw (struct glyph_string *s, int from, int to, int x, int y,
bool with_background)
{
block_input ();
struct frame *f = s->f;
struct face *face = s->face;
struct font_info *xftfont_info = (struct font_info *) s->font;
This is for when you need to extend a platform-independent struct (in
this case 'struct font') with platform-dependent additions.
> In any case, would you prefer using names like EColor, EPixmap, EGC, or
> Emacs_Color, Emacs_Pixmap, Emacs_GC?
The Emacs_ prefix is short enough, so I guess it's better.
next prev parent reply other threads:[~2019-05-09 17:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 4:28 Removing the usage of X structures (or their names) in independent code Alex Gramiak
2019-05-09 6:06 ` Eli Zaretskii
2019-05-09 16:26 ` Alex Gramiak
2019-05-09 17:12 ` Eli Zaretskii [this message]
2019-05-11 5:45 ` Alex Gramiak
2019-05-13 16:15 ` Alex Gramiak
2019-05-13 17:40 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8336lnh7rw.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=agrambot@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).