unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* set-frame-size should respect line-spacing!?
@ 2019-10-11 20:44 Ingo Lohmar
  2019-10-12  7:00 ` Eli Zaretskii
  0 siblings, 1 reply; 18+ messages in thread
From: Ingo Lohmar @ 2019-10-11 20:44 UTC (permalink / raw)
  To: emacs-devel

In Bug#37563, I reported that `fit-frame-to-buffer' ignores a default
value of `line-spacing' > 0, whence the buffer might not be tall enough
--- that's what happened with the `posframe' pkg that is, eg, used by
`company-posframe' to display completions. Martin fixed this and related
issues in window.el quickly and thoroughly, for which I am grateful.

Since I tested with a minimal example, however, I did not realize before
that there is another code path that directly uses the C function
`set-frame-size', with the same effect: If line-spacing is > 0 in the
frame, it is not accounted for, and the frame lacks a few pixels in
height (number of lines * "line-spacing effect").

This appears to be a bug: If asked for a frame N lines tall, N lines (of
default-font's character height plus the effect of line-spacing) should
fit, right?

Maybe this affords some opportunity to concentrate this code on either
the lisp or the C side..?



^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2019-10-14  8:06 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-11 20:44 set-frame-size should respect line-spacing!? Ingo Lohmar
2019-10-12  7:00 ` Eli Zaretskii
2019-10-12  7:12   ` Ingo Lohmar
2019-10-12  7:48     ` Eli Zaretskii
2019-10-12  8:25       ` martin rudalics
2019-10-12  8:25     ` martin rudalics
2019-10-12  9:45       ` Eli Zaretskii
2019-10-12  9:56         ` Ingo Lohmar
2019-10-12 11:03         ` martin rudalics
2019-10-12 13:11           ` Eli Zaretskii
2019-10-13  8:16             ` martin rudalics
2019-10-13  9:10               ` Eli Zaretskii
2019-10-13 12:15                 ` martin rudalics
2019-10-13 12:18                   ` Eli Zaretskii
2019-10-13 12:51                     ` martin rudalics
2019-10-13 13:20                       ` Eli Zaretskii
2019-10-13 17:06                         ` martin rudalics
2019-10-14  8:06                           ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).