From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: :extend t inheritance
Date: Sat, 26 Oct 2019 10:28:49 +0300
Message-ID: <8336fgvuby.fsf@gnu.org>
References: <87zhhrmcaq.fsf@kenko.localhost.com>
 <83o8y6xnmn.fsf@gnu.org> <20191026014911.7riwc5oq6epjhdiq@Ergus>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="142175"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: emacs-devel@gnu.org, ingo.lohmar@posteo.net
To: Ergus <spacibba@aol.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 26 09:29:13 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1iOGVd-000ap7-Kj
	for ged-emacs-devel@m.gmane.org; Sat, 26 Oct 2019 09:29:13 +0200
Original-Received: from localhost ([::1]:38558 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1iOGVc-0002Z0-Bl
	for ged-emacs-devel@m.gmane.org; Sat, 26 Oct 2019 03:29:12 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44466)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>) id 1iOGVU-0002MR-0n
 for emacs-devel@gnu.org; Sat, 26 Oct 2019 03:29:04 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37902)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
 id 1iOGVT-0001iB-5s; Sat, 26 Oct 2019 03:29:03 -0400
Original-Received: from [176.228.60.248] (port=1321 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1iOGVS-00067j-H3; Sat, 26 Oct 2019 03:29:02 -0400
In-reply-to: <20191026014911.7riwc5oq6epjhdiq@Ergus> (message from Ergus on
 Sat, 26 Oct 2019 03:49:13 +0200)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:241429
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/241429>

> Date: Sat, 26 Oct 2019 03:49:13 +0200
> From: Ergus <spacibba@aol.com>
> Cc: Ingo Lohmar <ingo.lohmar@posteo.net>, emacs-devel@gnu.org
> 
> I just added a branch `fix/inherit_extend_face` that fixes the issue
> with inheritance of the extend attribute with filter condition.

Thanks.

> There are two commits because I also detected another issue in gui I
> didn't see before because I don't use gui normally.
> 
> Please give it a look and if everything is fine I'll move it to master
> ASAP.

I took a look.  I don't understand some of the hunks, so please post
the rationale for the non-trivial changes there, otherwise it's hard
to review the changeset.