From: Eli Zaretskii <eliz@gnu.org>
To: Alan Mackenzie <acm@muc.de>
Cc: emacs-devel@gnu.org
Subject: Re: /* FIXME: Call signal_after_change! */ in callproc.c. Well, why not?
Date: Tue, 24 Dec 2019 17:58:03 +0200 [thread overview]
Message-ID: <8336d9wwac.fsf@gnu.org> (raw)
In-Reply-To: <20191224125111.GC3992@ACM> (message from Alan Mackenzie on Tue, 24 Dec 2019 12:51:11 +0000)
> Date: Tue, 24 Dec 2019 12:51:11 +0000
> Cc: emacs-devel@gnu.org
> From: Alan Mackenzie <acm@muc.de>
>
> > > This really ugly, IMO. And the code logic is very hard to follow and
> > > verify its correctness, given the various use cases.
>
> [ .... ]
>
> > I think the basic idea of my change is sound, but it is suboptimally
> > coded. My confusion, I think, arose from the use of the PREPARE
> > parameter in the call to insert_1_both, which creates several different
> > cases. This is a bad idea. If instead we put in a single call to
> > prepare_to_modify_buffer, this should be relatively easy to follow. One
> > or two comments would also be helpful.
>
> I think the following patch is better. What do you think?
Frankly, I don't like this, for the reasons I explained in my other
message. If you insist on jumping through these hoops just to avoid
an extra call to the modification hooks, please write a comment with
the detailed description of the logic of these calls and their
conditions, and how that ensures the paired calls with no extra calls.
Thanks.
next prev parent reply other threads:[~2019-12-24 15:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-21 17:23 /* FIXME: Call signal_after_change! */ in callproc.c. Well, why not? Alan Mackenzie
2019-12-21 18:11 ` Eli Zaretskii
2019-12-21 21:47 ` Alan Mackenzie
2019-12-22 18:38 ` Eli Zaretskii
2019-12-24 9:47 ` Alan Mackenzie
2019-12-24 12:51 ` Alan Mackenzie
2019-12-24 15:58 ` Eli Zaretskii [this message]
2019-12-24 15:47 ` Eli Zaretskii
2019-12-29 13:34 ` Alan Mackenzie
2019-12-29 16:23 ` Stefan Monnier
2020-01-03 8:45 ` Eli Zaretskii
2020-01-04 22:47 ` Alan Mackenzie
2020-01-05 18:17 ` Eli Zaretskii
2020-01-05 18:48 ` Alan Mackenzie
2020-01-21 20:34 ` Alan Mackenzie
2020-01-22 3:27 ` Eli Zaretskii
2020-01-22 20:05 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8336d9wwac.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=acm@muc.de \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).