From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: scratch/tzz/auth-source-reveal-mode 4a7c98d 3/3: Create and document auth-source-reveal-mode Date: Fri, 26 Jun 2020 17:24:26 +0300 Message-ID: <83366hsy5h.fsf@gnu.org> References: <20200622191653.26453.39420@vcs0.savannah.gnu.org> <20200622191656.2D20920A26@vcs0.savannah.gnu.org> <83a70sts32.fsf@gnu.org> <83v9jgs43x.fsf@gnu.org> <83sgejs25l.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="86907"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Ted Zlatanov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 26 16:26:34 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jopJJ-000MTi-PU for ged-emacs-devel@m.gmane-mx.org; Fri, 26 Jun 2020 16:26:33 +0200 Original-Received: from localhost ([::1]:46632 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jopJI-0000sw-Sd for ged-emacs-devel@m.gmane-mx.org; Fri, 26 Jun 2020 10:26:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49270) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jopHY-0007ie-MO for emacs-devel@gnu.org; Fri, 26 Jun 2020 10:24:44 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40108) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jopHX-0000ff-U7; Fri, 26 Jun 2020 10:24:43 -0400 Original-Received: from [176.228.60.248] (port=2724 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jopHX-0006LK-7f; Fri, 26 Jun 2020 10:24:43 -0400 In-Reply-To: (message from Ted Zlatanov on Fri, 26 Jun 2020 13:52:26 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252540 Archived-At: > From: Ted Zlatanov > Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org > Date: Fri, 26 Jun 2020 13:52:26 +0000 > > EZ> Perhaps if you describe the difficulties you bumped into in more > EZ> detail, we could help you overcome them? AFAICT, you never actually > EZ> described the specific problems you had. > > No, I didn't. I spent several hours investigating and the lack of > existing code that did this, plus the complexity of Emacs' display > internals, were discouraging. I'm not sure what is meant by "did this", but if you are talking about hiding some text and displaying something else in its stead, then Emacs is fill of examples of that. So I'm quite sure it should be possible to do what you want, if you show the code that you tried to use. > 1) the new minor auth-source-reveal-mode and the prettify-text > library/API: that won't change and has no hard dependency on static > compositions. > > 2) the internal implementation of the prettify-text library/API: that's > almost exactly like `prettify-symbols-mode', a part of the core. Your > major concern there (accessibility and internationalization) is valid > but it's equally valid against that existing part of the core. > > So again, I propose merging as is, and then spending time on a proper > reimplementation for both `prettify-symbols-mode' and the prettify-text > code. I can work on that reimplementation with guidance from this > mailing list. That will help me keep the changes smaller (the branch is > getting hard to maintain) and more targeted. I don't mind when will the dependency on static compositions replaced by more appropriate features, as long as we agree that it should be replaced. (OTOH, I don't see why we should rush towards merging.) Also, let's not call the library "prettify-text" or anything to that effect, because that's not what it is supposed to do, it's supposed to hide text by displaying something else in its stead. Thanks.