From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Redisplay slower in Emacs 28 than Emacs 27 Date: Tue, 08 Dec 2020 16:58:43 +0200 Message-ID: <83360g8huk.fsf@gnu.org> References: <877dptiro7.fsf@gnus.org> <87pn3lhcdd.fsf@gnus.org> <878sa9hbe2.fsf@gnus.org> <877dptfvae.fsf@gnus.org> <83czzl8qwu.fsf@gnu.org> <87sg8h78s8.fsf@gnus.org> <87h7ox71xc.fsf@gnus.org> <874kkx6zwj.fsf@gnus.org> <87zh2p5ksl.fsf@gnus.org> <87r1o15ifl.fsf@gnus.org> <87eek15gaf.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36272"; mail-complaints-to="usenet@ciao.gmane.io" Cc: ghe@sdf.org, emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 08 16:01:56 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kmeV2-0009LC-Pl for ged-emacs-devel@m.gmane-mx.org; Tue, 08 Dec 2020 16:01:56 +0100 Original-Received: from localhost ([::1]:33320 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmeV1-0002Js-Q9 for ged-emacs-devel@m.gmane-mx.org; Tue, 08 Dec 2020 10:01:55 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35858) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmeS4-0000ff-6M for emacs-devel@gnu.org; Tue, 08 Dec 2020 09:58:52 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51422) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmeS3-0001Ul-RR; Tue, 08 Dec 2020 09:58:51 -0500 Original-Received: from [176.228.60.248] (port=3459 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kmeS1-0002ud-Sj; Tue, 08 Dec 2020 09:58:50 -0500 In-Reply-To: <87eek15gaf.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 08 Dec 2020 00:48:24 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:260557 Archived-At: > From: Lars Ingebrigtsen > Date: Tue, 08 Dec 2020 00:48:24 +0100 > Cc: Eli Zaretskii , emacs-devel@gnu.org > > + (or (and cache > + (gethash specs find-image--cache)) > + (let ((orig-specs specs) > + image) > + (while (and specs (null image)) What will this do when the image file on disk changes? AFAIU, the current implementation will use the new image for the tool bar on the next redisplay opportunity, but this change will make us continue using the cached one?