From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: rgm@gnu.org, emacs-devel@gnu.org
Subject: Re: master e5392d3: Make easymenu downcase the menu symbol for greater backwards compat
Date: Tue, 02 Mar 2021 15:56:45 +0200 [thread overview]
Message-ID: <8335xd7j6q.fsf@gnu.org> (raw)
In-Reply-To: <87sg5eyrof.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 02 Mar 2021 07:51:12 +0100)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Tue, 02 Mar 2021 07:51:12 +0100
> Cc: emacs-devel@gnu.org
>
> Changing `lookup-key' to accept both forms (like Eli) suggests in a
> followup would be better, of course, if it can be done efficiently.
It should be as efficient as before for the case of a literal match;
it will be less efficient for a non-literal match or a mismatch.
> easymenu should also be extended with a form to allow explicitly
> specifying the symbol to use: For instance, if you change the name of
> the menu now, the symbol will also change. So for backwards
> compatibility, symbols should be specified when changing the name in
> easymenu calls.
That'd be fine with me, but then (a) we should make sure the symbols
are in fact specified in all the uses of easymenu that replace
existing menus; and (b) would that still leave easymenu so much more
convenient to justify the switch?
next prev parent reply other threads:[~2021-03-02 13:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210301212446.5364.12431@vcs0.savannah.gnu.org>
[not found] ` <20210301212448.4653D20E1B@vcs0.savannah.gnu.org>
2021-03-02 0:02 ` master e5392d3: Make easymenu downcase the menu symbol for greater backwards compat Glenn Morris
2021-03-02 5:57 ` Eli Zaretskii
2021-03-02 6:51 ` Lars Ingebrigtsen
2021-03-02 13:56 ` Eli Zaretskii [this message]
2021-03-03 14:36 ` Lars Ingebrigtsen
2021-03-03 14:41 ` Eli Zaretskii
2021-03-03 18:46 ` Stefan Kangas
2021-03-03 19:20 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8335xd7j6q.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).