From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: modus-themes ELPA and etc/themes
Date: Sat, 20 Mar 2021 22:23:45 +0200
Message-ID: <8335wpd166.fsf@gnu.org>
References: <jwvft0p3954.fsf-monnier+emacs@gnu.org>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="29075"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org
To: Stefan Monnier <monnier@iro.umontreal.ca>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Mar 20 21:24:24 2021
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1lNi92-0007Sb-1K
	for ged-emacs-devel@m.gmane-mx.org; Sat, 20 Mar 2021 21:24:24 +0100
Original-Received: from localhost ([::1]:42846 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1lNi91-00021M-2o
	for ged-emacs-devel@m.gmane-mx.org; Sat, 20 Mar 2021 16:24:23 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55982)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1lNi8T-0001ba-Hk
 for emacs-devel@gnu.org; Sat, 20 Mar 2021 16:23:49 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58803)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1lNi8S-0006dq-35; Sat, 20 Mar 2021 16:23:49 -0400
Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3585
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1lNi8R-0003QX-AR; Sat, 20 Mar 2021 16:23:47 -0400
In-Reply-To: <jwvft0p3954.fsf-monnier+emacs@gnu.org> (message from Stefan
 Monnier on Sat, 20 Mar 2021 15:52:39 -0400)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:266668
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/266668>

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Sat, 20 Mar 2021 15:52:39 -0400
> 
> The problem is due to the fact that the file is under `etc/themes` and
> is hence not processed by our autoloads machinery which would otherwise
> add something like
> 
>     (push (purecopy '(modus-themes 1 2 4)) package--builtin-versions)
> 
> to lisp/loaddefs.el.
> 
> There are various ways to fix this, but to me the simplest would be to
> move `etc/themes` to `lisp` (or at least to move `modus-themes.el`).

I'd rather we didn't move files around.  If nothing else, it makes
forensics harder down the line.  Besides, we had themes in that place
for too long to make such changes now, and for this minor reason on
top of that.

Why can't we take any of the other ways to fix this?