From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: How to add pseudo vector types Date: Thu, 22 Jul 2021 11:23:07 +0300 Message-ID: <8335s64v10.fsf@gnu.org> References: <83h7gw6pyj.fsf@gnu.org> <45EBF16A-C953-42C7-97D1-3A2BFEF7DD01@gmail.com> <83y2a764oy.fsf@gnu.org> <83v95b60fn.fsf@gnu.org> <00DD5BFE-D14E-449A-9319-E7B725DEBFB3@gmail.com> <83r1fz5xr9.fsf@gnu.org> <1AAB1BCC-362B-4249-B785-4E0530E15C60@gmail.com> <83czri67h0.fsf@gnu.org> <46BBFF88-76C3-4818-8805-5437409BEA93@gmail.com> <83wnpq46uk.fsf@gnu.org> <533BD53B-4E85-4E9E-B46A-346A5BBAD0F5@gmail.com> <258CB68D-1CC1-42C8-BDCD-2A8A8099B783@gmail.com> <1a776770-50b7-93cd-6591-c9a5b3a56eb8@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21160"; mail-complaints-to="usenet@ciao.gmane.io" Cc: cpitclaudel@gmail.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jul 22 10:24:04 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6Tzw-0005GO-Ff for ged-emacs-devel@m.gmane-mx.org; Thu, 22 Jul 2021 10:24:04 +0200 Original-Received: from localhost ([::1]:41212 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6Tzv-0006zI-2M for ged-emacs-devel@m.gmane-mx.org; Thu, 22 Jul 2021 04:24:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58084) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6TzO-0006IR-Bb for emacs-devel@gnu.org; Thu, 22 Jul 2021 04:23:30 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45320) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6TzM-0004iM-TL; Thu, 22 Jul 2021 04:23:28 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4437 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6TzM-00023E-FH; Thu, 22 Jul 2021 04:23:28 -0400 In-Reply-To: (message from Yuan Fu on Wed, 21 Jul 2021 23:10:14 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271456 Archived-At: > From: Yuan Fu > Date: Wed, 21 Jul 2021 23:10:14 -0400 > Cc: Clément Pit-Claudel , > emacs-devel > > Should I keep posting patches, or should I create a branch in /scratch? The latter, I think. > If the latter, how do I do it? You need write access to the Emacs repository. > @@ -96,33 +103,30 @@ ts_ensure_parsed (Lisp_Object parser) > ts_read_buffer (void *buffer, uint32_t byte_index, > TSPoint position, uint32_t *bytes_read) > { > - if (! BUFFER_LIVE_P ((struct buffer *) buffer)) > + if (!BUFFER_LIVE_P ((struct buffer *) buffer)) > error ("BUFFER is not live"); Is it really TRT to signal an error here? This is not code that would run from a user command, so signaling an error is not necessarily the useful response to this situation. Why not simply return without doing anything? > + // TODO BUF_ZV_BYTE? Do you want to discuss this? I'd prefer to have it the other way around: use BUF_ZV_BYTE by default. The callers could widen the buffer if they needed to access outside of the narrowing. > else > { > - beg = (char *) BYTE_POS_ADDR (byte_pos); > + beg = (char *) BUF_BYTE_ADDRESS (buffer, byte_pos); > len = next_char_len(byte_pos); The last line is incorrect, as it assumes the current buffer. You actually don't need that function, it's enough to use BYTES_BY_CHAR_HEAD on the address in 'beg'. > *bytes_read = (uint32_t) len; Is using uint32_t the restriction of tree-sitter? Doesn't it support reading more than 2 gigabytes? > +DEFUN ("tree-sitter-node-type", > + Ftree_sitter_node_type, Stree_sitter_node_type, 1, 1, 0, > + doc: /* Return the NODE's type as a symbol. */) > + (Lisp_Object node) > +{ > + CHECK_TS_NODE (node); > + TSNode ts_node = XTS_NODE (node)->node; > + const char *type = ts_node_type(ts_node); > + return intern_c_string (type); Why do we need to intern the string each time? can't we store the interned symbol there, instead of a C string, in the first place? Thanks.