From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: master 28bf387: Tweak Fdirectory_append for efficiency
Date: Sat, 24 Jul 2021 19:27:51 +0300
Message-ID: <8335s3zng8.fsf@gnu.org>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="4806"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org
To: Lars Ingebrigtsen <larsi@gnus.org>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jul 24 18:28:40 2021
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1m7KVz-00017E-Gl
	for ged-emacs-devel@m.gmane-mx.org; Sat, 24 Jul 2021 18:28:39 +0200
Original-Received: from localhost ([::1]:51050 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1m7KVy-0003Ks-Hy
	for ged-emacs-devel@m.gmane-mx.org; Sat, 24 Jul 2021 12:28:38 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56080)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1m7KVU-0002gR-M8
 for emacs-devel@gnu.org; Sat, 24 Jul 2021 12:28:08 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44696)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1m7KVU-0006ez-FX; Sat, 24 Jul 2021 12:28:08 -0400
Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4410
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1m7KVU-00024z-3W; Sat, 24 Jul 2021 12:28:08 -0400
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:271554
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/271554>

> --- a/src/fileio.c
> +++ b/src/fileio.c
> @@ -795,7 +795,8 @@ usage: (record DIRECTORY &rest COMPONENTS) */)
>        for (i = 0; i < nargs; i++)
>  	{
>  	  Lisp_Object arg = args[i];
> -	  if (STRING_MULTIBYTE (arg))
> +	  /* Use multibyte or all-ASCII strings as is. */
> +	  if (STRING_MULTIBYTE (arg) || SCHARS (arg) == SBYTES (arg))
>  	    elements[i] = arg;
>  	  else
>  	    elements[i] = make_multibyte_string (SSDATA (arg), SCHARS (arg),
> 

Isn't SCHARS (arg) == SBYTES (arg) true for any unibyte string, even
one that includes non-ASCII characters?