From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: master 28bf387: Tweak Fdirectory_append for efficiency
Date: Sat, 24 Jul 2021 19:27:51 +0300 [thread overview]
Message-ID: <8335s3zng8.fsf@gnu.org> (raw)
> --- a/src/fileio.c
> +++ b/src/fileio.c
> @@ -795,7 +795,8 @@ usage: (record DIRECTORY &rest COMPONENTS) */)
> for (i = 0; i < nargs; i++)
> {
> Lisp_Object arg = args[i];
> - if (STRING_MULTIBYTE (arg))
> + /* Use multibyte or all-ASCII strings as is. */
> + if (STRING_MULTIBYTE (arg) || SCHARS (arg) == SBYTES (arg))
> elements[i] = arg;
> else
> elements[i] = make_multibyte_string (SSDATA (arg), SCHARS (arg),
>
Isn't SCHARS (arg) == SBYTES (arg) true for any unibyte string, even
one that includes non-ASCII characters?
next reply other threads:[~2021-07-24 16:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-24 16:27 Eli Zaretskii [this message]
2021-07-24 16:29 ` master 28bf387: Tweak Fdirectory_append for efficiency Lars Ingebrigtsen
2021-07-24 16:36 ` Eli Zaretskii
2021-07-24 16:49 ` Lars Ingebrigtsen
2021-07-24 16:58 ` Eli Zaretskii
2021-07-24 17:05 ` Lars Ingebrigtsen
2021-07-24 17:13 ` Eli Zaretskii
2021-07-25 6:38 ` Lars Ingebrigtsen
2021-07-25 7:08 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8335s3zng8.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).