From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Patch proposal: display symbol source code in help buffers Date: Fri, 01 Oct 2021 10:24:08 +0300 Message-ID: <8335plfbs7.fsf@gnu.org> References: <875yuvlrz3.fsf@gnus.org> <87r1djixiw.fsf@gnus.org> <878rzrzpfz.fsf@localhost> <87zgs7y5wc.fsf@localhost> <87sfxyftrw.fsf@gnus.org> <87mto6ifd2.fsf@localhost> <83r1diz5k9.fsf@gnu.org> <87r1diqodc.fsf@localhost> <87ee9h27rm.fsf@gnus.org> <87wnmxcjhm.fsf@localhost> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25536"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, stefankangas@gmail.com, arthur.miller@live.com, emacs-devel@gnu.org To: Ihor Radchenko Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Oct 01 09:32:40 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mWD26-0006Qq-Is for ged-emacs-devel@m.gmane-mx.org; Fri, 01 Oct 2021 09:32:38 +0200 Original-Received: from localhost ([::1]:44378 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mWD25-00084M-Iq for ged-emacs-devel@m.gmane-mx.org; Fri, 01 Oct 2021 03:32:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38396) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mWCuA-0002KX-QP for emacs-devel@gnu.org; Fri, 01 Oct 2021 03:24:26 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44226) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mWCuA-0006Ug-7i; Fri, 01 Oct 2021 03:24:26 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2143 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mWCu9-00071b-Qx; Fri, 01 Oct 2021 03:24:26 -0400 In-Reply-To: <87wnmxcjhm.fsf@localhost> (message from Ihor Radchenko on Fri, 01 Oct 2021 15:05:57 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275963 Archived-At: > From: Ihor Radchenko > Cc: Eli Zaretskii , Stefan Kangas , > arthur.miller@live.com, emacs-devel@gnu.org > Date: Fri, 01 Oct 2021 15:05:57 +0800 > > + ;; Save mark for the old location, unless we just opened > + ;; the buffer or the point is not actually going to move. > + (unless (or (= 1 (point)) > + (= (point) position)) > + (push-mark nil t)) This assumes that if point is at BOB, we "just opened the buffer"? What if the user moves point, then returns to BOB? And why do you use 1 instead of point-min?