From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Crash with --enable-checking and some glyphs Date: Fri, 26 Nov 2021 18:27:59 +0200 Message-ID: <8335ni3mr4.fsf@gnu.org> References: <87h7c1u0cg.fsf@gnus.org> <87czmpu0ae.fsf@gnus.org> <87wnkxskvn.fsf@gnus.org> <87zgpt63m3.fsf@gnus.org> <83mtlt8vil.fsf@gnu.org> <87v90h6271.fsf@gnus.org> <83lf1d8uyw.fsf@gnu.org> <87r1b561kn.fsf@gnus.org> <871r35ziyl.fsf@gnus.org> <87sfvlwkrc.fsf_-_@gnus.org> <87sfvlh1zo.fsf@gmail.com> <87h7c0flfk.fsf@gnus.org> <874k807166.fsf@gmail.com> <87wnkwb8q7.fsf@gnus.org> <87sfvkb85w.fsf@gnus.org> <83wnkw469i.fsf@gnu.org> <87ee739kjx.fsf@gnus.org> <83h7bz2i9f.fsf@gnu.org> <87mtlrt2ei.fsf@gnus.org> <838rxb2c8i.fsf@gnu.org> <87a6hrt0ti.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13534"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rpluim@gmail.com, emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Nov 26 17:28:45 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mqe5c-0003LC-Pv for ged-emacs-devel@m.gmane-mx.org; Fri, 26 Nov 2021 17:28:44 +0100 Original-Received: from localhost ([::1]:60240 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mqe5b-0004h8-O5 for ged-emacs-devel@m.gmane-mx.org; Fri, 26 Nov 2021 11:28:43 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34638) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqe4p-0002k2-25 for emacs-devel@gnu.org; Fri, 26 Nov 2021 11:27:55 -0500 Original-Received: from [2001:470:142:3::e] (port=60472 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqe4o-0002qE-PE; Fri, 26 Nov 2021 11:27:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=pQCD/Fzz50tKlfjqJMo57G8U6XbS+czpULRz4iu4oFQ=; b=bwGbLEDL+evY gF7fndBYevEgg0wNsAbz3MXy+OAdsHY3TP3Yy5bBF5E1Yr5nYwThPJbyrq/FX/mN0vTFa8P+EUlzg R5PXPZc7jawRvYftxJDbEVbKEU7qvheWhjjSPC6rp7gbdlPp8Rv/ecBHZV+L2UGBcy2IN0dgIiLJN b/lJSmh7yRuMYFlXkhrOfW23LgNh+uB9ZUwaZQOmLS6MigqOjPWFqSLdG9jhVvDnerCN2/DfMXixT 7rXG1z3tmWWSbi6nlpyfXX9eLSOEx0bvoQr2XpameGmLBG9dQWz0+8q7/oKACqJ5y2C1WBNE0oEZy ODIJoBfIJmBUyyPJV1mmxg==; Original-Received: from [87.69.77.57] (port=4073 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqe4o-0006y4-Fw; Fri, 26 Nov 2021 11:27:54 -0500 In-Reply-To: <87a6hrt0ti.fsf@gnus.org> (message from Lars Ingebrigtsen on Fri, 26 Nov 2021 16:04:57 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:280259 Archived-At: > From: Lars Ingebrigtsen > Cc: rpluim@gmail.com, emacs-devel@gnu.org > Date: Fri, 26 Nov 2021 16:04:57 +0100 > > Eli Zaretskii writes: > > > if (pcm) > > { > > it->phys_ascent = pcm->ascent + boff; > > it->phys_descent = pcm->descent - boff; > > it->pixel_width = pcm->width; > > > > please tell what are the values of pcm->ascent and pcm->descent. > > > > I want to know whether the font is the culprit or some code of ours > > overrides the value from the font. Then we can devise the solution. > > gdb) next > 30909 it->phys_ascent = pcm->ascent + boff; > (gdb) p pcm->ascent > $1 = 18 > (gdb) p pcm->descent > $2 = -3 So the glyph metrics also report a negative descent. But what about the font? We don't use the above for it->descent, at least not directly. So where in the code did it->descent get negative?